@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Let Aphlict listen on the specified host
Summary: We allow user to specify the host to listen to but we listen on 127.0.0.1 instead.
Test Plan:
Hardcoded the path and verified that I can connect to the host from other machine.
Verified that `localhost` still doesn't allow remote connections.
Reviewers: ddfisher, epriestley, nh
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D4238
+4
-2
+1
support/aphlict/server/aphlict_launcher.php
+1
support/aphlict/server/aphlict_launcher.php
···
59
59
$server_argv = array();
60
60
$server_argv[] = csprintf('--port=%s', $client_uri->getPort());
61
61
$server_argv[] = csprintf('--admin=%s', $server_uri->getPort());
62
+
$server_argv[] = csprintf('--host=%s', $server_uri->getDomain());
62
63
63
64
if ($user) {
64
65
$server_argv[] = csprintf('--user=%s', $user);
+3
-2
support/aphlict/server/aphlict_server.js
+3
-2
support/aphlict/server/aphlict_server.js
···
3
3
*
4
4
* sudo node aphlict_server.js --user=aphlict
5
5
*
6
-
* You can also specify `port`, `admin` and `log`.
6
+
* You can also specify `port`, `admin`, `host` and `log`.
7
7
*/
8
8
9
9
var config = parse_command_line_arguments(process.argv);
···
12
12
var config = {
13
13
port : 22280,
14
14
admin : 22281,
15
+
host : '127.0.0.1',
15
16
user : null,
16
17
log: '/var/log/aphlict.log'
17
18
};
···
200
201
response.end();
201
202
}
202
203
203
-
}).listen(config.admin, '127.0.0.1');
204
+
}).listen(config.admin, config.host);
204
205
205
206
function broadcast(data) {
206
207
for (var client_id in clients) {