@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
[Redesign] Clean up timeline images
Summary: Ref T8099, Timeline images should be 28 and 50, I previously had a border adding the additonal size, but changed that to an inset shadow.
Test Plan: Staring. Intensifies.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D13368
+18
-15
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => '173fc33c',
10
+
'core.pkg.css' => '604293a7',
11
11
'core.pkg.js' => 'f1e8abd7',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => 'fe951924',
···
150
150
'rsrc/css/phui/phui-status.css' => '888cedb8',
151
151
'rsrc/css/phui/phui-tag-view.css' => '402691cc',
152
152
'rsrc/css/phui/phui-text.css' => 'cf019f54',
153
-
'rsrc/css/phui/phui-timeline-view.css' => '2d181f3f',
153
+
'rsrc/css/phui/phui-timeline-view.css' => '47b18876',
154
154
'rsrc/css/phui/phui-workboard-view.css' => '0cac51a4',
155
155
'rsrc/css/phui/phui-workpanel-view.css' => '4bdc2562',
156
156
'rsrc/css/sprite-login.css' => 'a3526809',
···
793
793
'phui-tag-view-css' => '402691cc',
794
794
'phui-text-css' => 'cf019f54',
795
795
'phui-theme-css' => 'd4a49411',
796
-
'phui-timeline-view-css' => '2d181f3f',
796
+
'phui-timeline-view-css' => '47b18876',
797
797
'phui-workboard-view-css' => '0cac51a4',
798
798
'phui-workpanel-view-css' => '4bdc2562',
799
799
'phuix-action-list-view' => 'b5c256b8',
+10
-7
src/view/phui/PHUITimelineEventView.php
+10
-7
src/view/phui/PHUITimelineEventView.php
···
354
354
),
355
355
'');
356
356
357
-
$image = phutil_tag(
358
-
'div',
359
-
array(
360
-
'style' => 'background-image: url('.$image_uri.')',
361
-
'class' => 'phui-timeline-image',
362
-
),
363
-
'');
357
+
$image = null;
358
+
if ($image_uri) {
359
+
$image = phutil_tag(
360
+
'div',
361
+
array(
362
+
'style' => 'background-image: url('.$image_uri.')',
363
+
'class' => 'phui-timeline-image',
364
+
),
365
+
'');
366
+
}
364
367
365
368
$content_classes = array();
366
369
$content_classes[] = 'phui-timeline-content';
+5
-5
webroot/rsrc/css/phui/phui-timeline-view.css
+5
-5
webroot/rsrc/css/phui/phui-timeline-view.css
···
105
105
}
106
106
107
107
.device-desktop .phui-timeline-major-event .phui-timeline-image {
108
-
width: 48px;
109
-
height: 48px;
108
+
width: 50px;
109
+
height: 50px;
110
110
top: 0px;
111
111
left: -62px;
112
112
}
113
113
114
114
.device-desktop .phui-timeline-minor-event .phui-timeline-image {
115
-
width: 26px;
116
-
height: 26px;
117
-
background-size: 26px auto;
115
+
width: 28px;
116
+
height: 28px;
117
+
background-size: 28px auto;
118
118
left: -41px;
119
119
}
120
120