@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Continue reducing callsites to ArcanistDifferentialRevisionStatus in transactions
Summary: Ref T2543. Cleans up some more references to ArcanistDifferentialRevisionStatus, moving toward getting rid of it completely.
Test Plan: Planned changes, requested review, inspected the "close" one since it isn't trivial to trigger.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T2543
Differential Revision: https://secure.phabricator.com/D18408
+4
-10
+2
-6
src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
+2
-6
src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
···
35
35
}
36
36
37
37
public function applyInternalEffects($object, $value) {
38
-
$status_closed = ArcanistDifferentialRevisionStatus::CLOSED;
39
-
$status_accepted = ArcanistDifferentialRevisionStatus::ACCEPTED;
40
-
41
-
$old_status = $object->getStatus();
38
+
$was_accepted = $object->isAccepted();
42
39
40
+
$status_closed = ArcanistDifferentialRevisionStatus::CLOSED;
43
41
$object->setStatus($status_closed);
44
-
45
-
$was_accepted = ($old_status == $status_accepted);
46
42
47
43
$object->setProperty(
48
44
DifferentialRevision::PROPERTY_CLOSED_FROM_ACCEPTED,
+1
-2
src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
+1
-2
src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
···
46
46
}
47
47
48
48
public function generateOldValue($object) {
49
-
$status_planned = ArcanistDifferentialRevisionStatus::CHANGES_PLANNED;
50
-
return ($object->getStatus() == $status_planned);
49
+
return $object->isChangePlanned();
51
50
}
52
51
53
52
public function applyInternalEffects($object, $value) {
+1
-2
src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php
+1
-2
src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php
···
27
27
}
28
28
29
29
public function generateOldValue($object) {
30
-
$status_review = ArcanistDifferentialRevisionStatus::NEEDS_REVIEW;
31
-
return ($object->getStatus() == $status_review);
30
+
return $object->isNeedsReview();
32
31
}
33
32
34
33
public function applyInternalEffects($object, $value) {