+2 -2

src/__phutil_library_map__.php

reviewed

··· 495 495 'DifferentialResponsibleViewerFunctionDatasource' => 'applications/differential/typeahead/DifferentialResponsibleViewerFunctionDatasource.php', 496 496 'DifferentialRevertPlanField' => 'applications/differential/customfield/DifferentialRevertPlanField.php', 497 497 'DifferentialReviewedByField' => 'applications/differential/customfield/DifferentialReviewedByField.php', 498 498 - 'DifferentialReviewer' => 'applications/differential/storage/DifferentialReviewer.php', 499 498 'DifferentialReviewerDatasource' => 'applications/differential/typeahead/DifferentialReviewerDatasource.php', 500 499 'DifferentialReviewerForRevisionEdgeType' => 'applications/differential/edge/DifferentialReviewerForRevisionEdgeType.php', 500 500 + 'DifferentialReviewerProxy' => 'applications/differential/storage/DifferentialReviewerProxy.php', 501 501 'DifferentialReviewerStatus' => 'applications/differential/constants/DifferentialReviewerStatus.php', 502 502 'DifferentialReviewersAddBlockingReviewersHeraldAction' => 'applications/differential/herald/DifferentialReviewersAddBlockingReviewersHeraldAction.php', 503 503 'DifferentialReviewersAddBlockingSelfHeraldAction' => 'applications/differential/herald/DifferentialReviewersAddBlockingSelfHeraldAction.php', ··· 5125 5125 'DifferentialResponsibleViewerFunctionDatasource' => 'PhabricatorTypeaheadDatasource', 5126 5126 'DifferentialRevertPlanField' => 'DifferentialStoredCustomField', 5127 5127 'DifferentialReviewedByField' => 'DifferentialCoreCustomField', 5128 5128 - 'DifferentialReviewer' => 'Phobject', 5129 5128 'DifferentialReviewerDatasource' => 'PhabricatorTypeaheadCompositeDatasource', 5130 5129 'DifferentialReviewerForRevisionEdgeType' => 'PhabricatorEdgeType', 5130 5130 + 'DifferentialReviewerProxy' => 'Phobject', 5131 5131 'DifferentialReviewerStatus' => 'Phobject', 5132 5132 'DifferentialReviewersAddBlockingReviewersHeraldAction' => 'DifferentialReviewersHeraldAction', 5133 5133 'DifferentialReviewersAddBlockingSelfHeraldAction' => 'DifferentialReviewersHeraldAction',

+1 -1

src/applications/differential/controller/DifferentialCommentSaveController.php

reviewed

··· 64 64 if (isset($current_reviewers[$reviewer_phid])) { 65 65 continue; 66 66 } 67 67 - $reviewer = new DifferentialReviewer( 67 67 + $reviewer = new DifferentialReviewerProxy( 68 68 $reviewer_phid, 69 69 array( 70 70 'status' => DifferentialReviewerStatus::STATUS_ADDED,

+1 -1

src/applications/differential/customfield/DifferentialReviewersField.php

reviewed

··· 84 84 } 85 85 86 86 foreach ($new_reviewers as $phid => $status) { 87 87 - $new_reviewers[$phid] = new DifferentialReviewer( 87 87 + $new_reviewers[$phid] = new DifferentialReviewerProxy( 88 88 $phid, 89 89 array( 90 90 'status' => $status,

+1 -1

src/applications/differential/editor/DifferentialTransactionEditor.php

reviewed

··· 474 474 475 475 $owner_phid = $object->getAuthorPHID(); 476 476 if ($owner_phid) { 477 477 - $reviewer = new DifferentialReviewer( 477 477 + $reviewer = new DifferentialReviewerProxy( 478 478 $owner_phid, 479 479 array( 480 480 'status' => DifferentialReviewerStatus::STATUS_ADDED,

+3 -1

src/applications/differential/query/DifferentialRevisionQuery.php

reviewed

··· 1008 1008 $revision_edges = $edges[$revision->getPHID()][$edge_type]; 1009 1009 $reviewers = array(); 1010 1010 foreach ($revision_edges as $reviewer_phid => $edge) { 1011 1011 - $reviewer = new DifferentialReviewer($reviewer_phid, $edge['data']); 1011 1011 + $reviewer = new DifferentialReviewerProxy( 1012 1012 + $reviewer_phid, 1013 1013 + $edge['data']); 1012 1014 1013 1015 if ($this->needReviewerAuthority) { 1014 1016 if (!$viewer_phid) {

+1 -1

src/applications/differential/storage/DifferentialReviewer.php src/applications/differential/storage/DifferentialReviewerProxy.php

reviewed

··· 1 1 <?php 2 2 3 3 - final class DifferentialReviewer extends Phobject { 3 3 + final class DifferentialReviewerProxy extends Phobject { 4 4 5 5 private $reviewerPHID; 6 6 private $status;

+1 -1

src/applications/differential/storage/DifferentialRevision.php

reviewed

··· 403 403 } 404 404 405 405 public function attachReviewerStatus(array $reviewers) { 406 406 - assert_instances_of($reviewers, 'DifferentialReviewer'); 406 406 + assert_instances_of($reviewers, 'DifferentialReviewerProxy'); 407 407 408 408 $this->reviewerStatus = $reviewers; 409 409 return $this;

+1 -1

src/applications/differential/view/DifferentialReviewersView.php

reviewed

··· 7 7 private $diff; 8 8 9 9 public function setReviewers(array $reviewers) { 10 10 - assert_instances_of($reviewers, 'DifferentialReviewer'); 10 10 + assert_instances_of($reviewers, 'DifferentialReviewerProxy'); 11 11 $this->reviewers = $reviewers; 12 12 return $this; 13 13 }