@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use --master-data, not --dump-slave, in bin/storage dump
Summary: These flags do slightly different things, I actually want --master-data here. My test databases are setup half-weird and work with either statement, which is why I missed this.
Test Plan: Ran a dump against master, got the right CHANGE MASTER statement with no warnings.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D15716
+3
-3
+1
-1
src/docs/user/cluster/cluster_databases.diviner
+1
-1
src/docs/user/cluster/cluster_databases.diviner
···
302
302
network).
303
303
304
304
With the `--for-replica` flag, the `bin/storage dump` command creates dumps
305
-
with `--dump-slave`, which includes a `CHANGE MASTER` statement in the output.
305
+
with `--master-data`, which includes a `CHANGE MASTER` statement in the output.
306
306
This may be helpful when initially setting up new replicas, as it can make it
307
307
easier to change the binlog coordinates to the correct position for the dump.
308
308
+2
-2
src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php
+2
-2
src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php
···
13
13
array(
14
14
'name' => 'for-replica',
15
15
'help' => pht(
16
-
'Add __--dump-slave__ to the __mysqldump__ command, '.
16
+
'Add __--master-data__ to the __mysqldump__ command, '.
17
17
'generating a CHANGE MASTER statement in the output.'),
18
18
),
19
19
));
···
57
57
$argv[] = '--default-character-set=utf8';
58
58
59
59
if ($args->getArg('for-replica')) {
60
-
$argv[] = '--dump-slave';
60
+
$argv[] = '--master-data';
61
61
}
62
62
63
63
$argv[] = '-u';