@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix method visibility for `PhabricatorApplicationTransactionEditor` methods
Summary: Ref T6822.
Test Plan: Visual inspection. These methods are only called from within the `PhabricatorApplicationTransactionEditor` class.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T6822
Differential Revision: https://secure.phabricator.com/D11244
+6
-6
+3
-3
src/applications/releeph/editor/ReleephProductEditor.php
+3
-3
src/applications/releeph/editor/ReleephProductEditor.php
···
19
19
return $types;
20
20
}
21
21
22
-
public function getCustomTransactionOldValue(
22
+
protected function getCustomTransactionOldValue(
23
23
PhabricatorLiskDAO $object,
24
24
PhabricatorApplicationTransaction $xaction) {
25
25
···
29
29
}
30
30
}
31
31
32
-
public function getCustomTransactionNewValue(
32
+
protected function getCustomTransactionNewValue(
33
33
PhabricatorLiskDAO $object,
34
34
PhabricatorApplicationTransaction $xaction) {
35
35
···
39
39
}
40
40
}
41
41
42
-
public function applyCustomInternalTransaction(
42
+
protected function applyCustomInternalTransaction(
43
43
PhabricatorLiskDAO $object,
44
44
PhabricatorApplicationTransaction $xaction) {
45
45
$new = $xaction->getNewValue();
+3
-3
src/applications/releeph/editor/ReleephRequestTransactionalEditor.php
+3
-3
src/applications/releeph/editor/ReleephRequestTransactionalEditor.php
···
26
26
return $types;
27
27
}
28
28
29
-
public function getCustomTransactionOldValue(
29
+
protected function getCustomTransactionOldValue(
30
30
PhabricatorLiskDAO $object,
31
31
PhabricatorApplicationTransaction $xaction) {
32
32
···
58
58
}
59
59
}
60
60
61
-
public function getCustomTransactionNewValue(
61
+
protected function getCustomTransactionNewValue(
62
62
PhabricatorLiskDAO $object,
63
63
PhabricatorApplicationTransaction $xaction) {
64
64
···
74
74
}
75
75
}
76
76
77
-
public function applyCustomInternalTransaction(
77
+
protected function applyCustomInternalTransaction(
78
78
PhabricatorLiskDAO $object,
79
79
PhabricatorApplicationTransaction $xaction) {
80
80