Conduit: Fix PHP 8.1 "strlen(null)" exception in file.allocate

@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge

phorge phabricator

fork

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/conduit/FileAllocateConduitAPIMethod.php:68]
```

Closes T16417

Test Plan: Go to http://phorge.localhost/conduit/method/file.allocate/ and press the "Call Method" button

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16417

Differential Revision: https://we.phorge.it/D26629

Andre Klapper 4 months ago 794d4545 ab6a6273

+1 -1

1 changed file

expand all

src

applications

files

conduit

FileAllocateConduitAPIMethod.php

+1 -1

src/applications/files/conduit/FileAllocateConduitAPIMethod.php

··· 65 65 ->executeOne(); 66 66 } 67 67 68 - if (strlen($name) && !$hash && !$file) { 68 + if (phutil_nonempty_string($name) && !$hash && !$file) { 69 69 if ($length > PhabricatorFileStorageEngine::getChunkThreshold()) { 70 70 // If we don't have a hash, but this file is large enough to store in 71 71 // chunks and thus may be resumable, try to find a partially uploaded

Configure Feed

Configure Feed