@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Explain the relationship between "Runnable" and "Restartable" more clearly in Build Plans
Summary: See PHI1153. The "Runnable" and "Restartable" behaviors interact (to click "restart", you must be able to run the build AND it must be restartable). Make this more clear.
Test Plan: {F6301739}
Reviewers: amckinley
Reviewed By: amckinley
Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam
Differential Revision: https://secure.phabricator.com/D20307
+11
-7
+11
-7
src/applications/harbormaster/plan/HarbormasterBuildPlanBehavior.php
+11
-7
src/applications/harbormaster/plan/HarbormasterBuildPlanBehavior.php
···
350
350
->setKey(self::BEHAVIOR_RESTARTABLE)
351
351
->setEditInstructions(
352
352
pht(
353
-
'Usually, builds may be restarted. This may be useful if you '.
354
-
'suspect a build has failed for environmental or circumstantial '.
355
-
'reasons unrelated to the actual code, and want to give it '.
356
-
'another chance at glory.'.
353
+
'Usually, builds may be restarted by users who have permission '.
354
+
'to edit the related build plan. (You can change who is allowed '.
355
+
'to restart a build by adjusting the "Runnable" behavior.)'.
356
+
"\n\n".
357
+
'Restarting a build may be useful if you suspect it has failed '.
358
+
'for environmental or circumstantial reasons unrelated to the '.
359
+
'actual code, and want to give it another chance at glory.'.
357
360
"\n\n".
358
361
'If you want to prevent a build from being restarted, you can '.
359
-
'change the behavior here. This may be useful to prevent '.
360
-
'accidents where a build with a dangerous side effect (like '.
361
-
'deployment) is restarted improperly.'))
362
+
'change when it may be restarted by adjusting this behavior. '.
363
+
'This may be useful to prevent accidents where a build with a '.
364
+
'dangerous side effect (like deployment) is restarted '.
365
+
'improperly.'))
362
366
->setName(pht('Restartable'))
363
367
->setOptions($restart_options),
364
368
id(new self())