@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery
Summary:
DiffusionCommitQuery passed duplicate CommitterIdentity values to PhabricatorRepositoryIdentityQuery, making logs slightly more noisy.
Thus run `array_unique()` before passing.
Closes T16032
Test Plan: Go to http://phorge.localhost/diffusion/commit/query/all/ and look at SQL query in Dark Console before and after applying patch.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T16032
Differential Revision: https://we.phorge.it/D25964
+2
-2
+2
-2
src/applications/diffusion/query/DiffusionCommitQuery.php
+2
-2
src/applications/diffusion/query/DiffusionCommitQuery.php
···
439
439
}
440
440
441
441
if ($this->needIdentities) {
442
-
$identity_phids = array_merge(
442
+
$identity_phids = array_unique(array_merge(
443
443
mpull($commits, 'getAuthorIdentityPHID'),
444
-
mpull($commits, 'getCommitterIdentityPHID'));
444
+
mpull($commits, 'getCommitterIdentityPHID')));
445
445
446
446
$data = id(new PhabricatorRepositoryIdentityQuery())
447
447
->withPHIDs($identity_phids)