@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix undefined variables in Subversion
Summary: These variables won't be in scope in Subversion.
See: <https://secure.phabricator.com/rP2ff5541fc59c4be7abd733a39e12db8358004f7a>
Auditors: btrahan
+3
-2
+3
-2
src/applications/diffusion/controller/DiffusionCommitController.php
+3
-2
src/applications/diffusion/controller/DiffusionCommitController.php
···
519
519
}
520
520
}
521
521
522
+
$author_phid = $data->getCommitDetail('authorPHID');
523
+
$author_name = $data->getAuthorName();
524
+
522
525
if (!$repository->isSVN()) {
523
526
$authored_info = id(new PHUIStatusItemView());
524
527
// TODO: In Git, a distinct authorship date is available. When present,
525
528
// we should show it here.
526
529
527
-
$author_phid = $data->getCommitDetail('authorPHID');
528
-
$author_name = $data->getAuthorName();
529
530
if ($author_phid) {
530
531
$authored_info->setTarget($handles[$author_phid]->renderLink());
531
532
} else if (strlen($author_name)) {