recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

a11y: Set aria-labels for top bar dropdown links next to logo/wordmark

Summary:
Links should have a discernible name per https://dequeuniversity.com/rules/axe/4.10/link-name.

This is not the case for the dropdown links (notifications, chat messages, installation setup, account setup) in the top bar next to the Phorge logo/wordmark when a dropdown link has a value of "0" / is empty (means: hidden for installation and account setup, or displayed without a number for notifications and chat messages). Thus add an `aria-label` attribute for screenreader use.

Refs T16072

Test Plan:
* Go to http://phorge.localhost while logged in.
* Inspect the dropdown links in the top bar next to the Phorge logo/wordmark.
* Optionally, run an Accessibility check in Chromium Lighthouse, or try to use Phorge with screenreader software.

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16072

Differential Revision: https://we.phorge.it/D26235

Andre Klapper 7a6579d4 6af6563d

+4
+4
src/view/page/menu/PhabricatorMainMenuView.php
··· 403 403 'href' => '/conpherence/', 404 404 'class' => implode(' ', $container_classes), 405 405 'id' => $message_id, 406 + 'aria-label' => pht('Chat Messages'), 406 407 ), 407 408 array( 408 409 $message_icon_tag, ··· 484 485 'href' => '/notification/', 485 486 'class' => implode(' ', $container_classes), 486 487 'id' => $bubble_id, 488 + 'aria-label' => pht('Notifications'), 487 489 ), 488 490 array($icon_tag, $count_tag)); 489 491 ··· 563 565 'href' => '/config/issue/', 564 566 'class' => implode(' ', $container_classes), 565 567 'id' => $setup_id, 568 + 'aria-label' => pht('Unresolved Setup Issues'), 566 569 ), 567 570 array( 568 571 $setup_icon_tag, ··· 629 632 'href' => $settings_uri, 630 633 'class' => 'setup-unread', 631 634 'id' => $bubble_id, 635 + 'aria-label' => pht('Account Setup Issues'), 632 636 ), 633 637 array( 634 638 $user_icon,