@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix operator error in Pholio with PHP 7.1
Summary: Fixes T12166. We don't actually need this variable, so removing it.
Test Plan: Upload a new mock, edit a mock, view list of mocks.
Reviewers: epriestley, Mnkras, acs-ferreira
Reviewed By: epriestley, Mnkras, acs-ferreira
Subscribers: acs-ferreira, Korvin
Maniphest Tasks: T12166
Differential Revision: https://secure.phabricator.com/D17260
authored by
Chad Little
and committed by
chad
7a947947
1be3ef02
+1
-4
+1
-4
src/applications/pholio/view/PholioMockImagesView.php
+1
-4
src/applications/pholio/view/PholioMockImagesView.php
···
180
180
'pholio-mock-view',
181
181
$this->getBehaviorConfig());
182
182
183
-
$mockview = '';
184
-
185
183
$mock_wrapper = javelin_tag(
186
184
'div',
187
185
array(
···
220
218
),
221
219
'');
222
220
223
-
$mockview[] = phutil_tag(
221
+
return phutil_tag(
224
222
'div',
225
223
array(
226
224
'class' => 'pholio-mock-image-container',
···
228
226
),
229
227
array($mock_wrapper, $inline_comments_holder));
230
228
231
-
return $mockview;
232
229
}
233
230
234
231
private function getImagePageURI(PholioImage $image, PholioMock $mock) {