@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Respect unified view in Diffusion
Summary: Ref T2009. Respect preference and make 1up/2up options work properly.
Test Plan: Toggled 1up vs 2up in Diffusion.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T2009
Differential Revision: https://secure.phabricator.com/D12015
+5
-4
+5
-4
src/applications/diffusion/controller/DiffusionDiffController.php
+5
-4
src/applications/diffusion/controller/DiffusionDiffController.php
···
77
77
'action' => 'rendering-ref',
78
78
)));
79
79
80
-
$parser->setCharacterEncoding($request->getStr('encoding'));
81
-
$parser->setHighlightAs($request->getStr('highlight'));
80
+
$parser->readParametersFromRequest($request);
82
81
83
82
$coverage = $drequest->loadCoverage();
84
83
if ($coverage) {
···
126
125
$spec = $request->getStr('range');
127
126
list($range_s, $range_e, $mask) =
128
127
DifferentialChangesetParser::parseRangeSpecification($spec);
129
-
$output = $parser->render($range_s, $range_e, $mask);
128
+
129
+
$parser->setRange($range_s, $range_e);
130
+
$parser->setMask($mask);
130
131
131
132
return id(new PhabricatorChangesetResponse())
132
-
->setRenderedChangeset($output);
133
+
->setRenderedChangeset($parser->renderChangeset());
133
134
}
134
135
}