@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make the 404 page device friendly.
Summary: Fixes T5686.
Test Plan: Viewed in iOS simulator and Chrome with various viewport sizes - looked good!
Reviewers: chad, epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T5686
Differential Revision: https://secure.phabricator.com/D10082
+13
-8
+8
-7
src/aphront/response/Aphront404Response.php
+8
-7
src/aphront/response/Aphront404Response.php
···
7
7
}
8
8
9
9
public function buildResponseString() {
10
-
$failure = new AphrontRequestFailureView();
11
-
$failure->setHeader('404 Not Found');
12
-
$failure->appendChild(phutil_tag('p', array(), pht(
10
+
$failure = id(new AphrontRequestFailureView())
11
+
->setHeader(pht('404 Not Found'))
12
+
->appendChild(phutil_tag('p', array(), pht(
13
13
'The page you requested was not found.')));
14
14
15
-
$view = new PhabricatorStandardPageView();
16
-
$view->setTitle('404 Not Found');
17
-
$view->setRequest($this->getRequest());
18
-
$view->appendChild($failure);
15
+
$view = id(new PhabricatorStandardPageView())
16
+
->setTitle('404 Not Found')
17
+
->setRequest($this->getRequest())
18
+
->setDeviceReady(true)
19
+
->appendChild($failure);
19
20
20
21
return $view->render();
21
22
}
+5
-1
webroot/rsrc/css/aphront/request-failure-view.css
+5
-1
webroot/rsrc/css/aphront/request-failure-view.css