@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Provide default values for table view properties which are `count`ed
Summary:
PHP 7.2 has changed the behavior of `count`, you must provide an array or `Countable` as a parameter, otherwise a warning is generated. These two class members are counted during rendering, and are commonly left as null properties.
https://wiki.php.net/rfc/counting_non_countables
Test Plan: Browsed around my install and stopped seeing `count(): Parameter must be an array or an object that implements Countable at [AphrontTableView.php:153]` everywhere.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D19140
+2
-2
+2
-2
src/view/control/AphrontTableView.php
+2
-2
src/view/control/AphrontTableView.php
···
4
4
5
5
protected $data;
6
6
protected $headers;
7
-
protected $shortHeaders;
7
+
protected $shortHeaders = array();
8
8
protected $rowClasses = array();
9
9
protected $columnClasses = array();
10
10
protected $cellClasses = array();
···
21
21
protected $sortParam;
22
22
protected $sortSelected;
23
23
protected $sortReverse;
24
-
protected $sortValues;
24
+
protected $sortValues = array();
25
25
private $deviceReadyTable;
26
26
27
27
public function __construct(array $data) {