@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Eat right-click, etc., on autocomplete suggestion menu
Summary:
Ref T10163. If you right-click the suggestion menu, just eat it. I don't think we can really choose a different behavior reasonably, or that users have any reason to do this.
I'm leaving "clicking the header dismisses it", I think that behavior is fine and reasonable.
Test Plan: Control-clicked a suggestion menu, didn't trigger a suggestion.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10163
Differential Revision: https://secure.phabricator.com/D15042
+16
-8
+8
-8
resources/celerity/map.php
+8
-8
resources/celerity/map.php
···
507
507
'rsrc/js/phui/behavior-phui-object-box-tabs.js' => '2bfa2836',
508
508
'rsrc/js/phuix/PHUIXActionListView.js' => 'b5c256b8',
509
509
'rsrc/js/phuix/PHUIXActionView.js' => '8cf6d262',
510
-
'rsrc/js/phuix/PHUIXAutocomplete.js' => 'fc10c813',
510
+
'rsrc/js/phuix/PHUIXAutocomplete.js' => '21dc9144',
511
511
'rsrc/js/phuix/PHUIXDropdownMenu.js' => 'bd4c8dca',
512
512
'rsrc/js/phuix/PHUIXFormControl.js' => '8fba1997',
513
513
'rsrc/js/phuix/PHUIXIconView.js' => 'bff6884b',
···
836
836
'phui-workpanel-view-css' => 'adec7699',
837
837
'phuix-action-list-view' => 'b5c256b8',
838
838
'phuix-action-view' => '8cf6d262',
839
-
'phuix-autocomplete' => 'fc10c813',
839
+
'phuix-autocomplete' => '21dc9144',
840
840
'phuix-dropdown-menu' => 'bd4c8dca',
841
841
'phuix-form-control-view' => '8fba1997',
842
842
'phuix-icon-view' => 'bff6884b',
···
1003
1003
'javelin-workflow',
1004
1004
'javelin-stratcom',
1005
1005
'conpherence-thread-manager',
1006
+
),
1007
+
'21dc9144' => array(
1008
+
'javelin-install',
1009
+
'javelin-dom',
1010
+
'phuix-icon-view',
1011
+
'phabricator-prefab',
1006
1012
),
1007
1013
'2290aeef' => array(
1008
1014
'javelin-install',
···
2085
2091
'javelin-mask',
2086
2092
'javelin-behavior-device',
2087
2093
'phabricator-keyboard-shortcut',
2088
-
),
2089
-
'fc10c813' => array(
2090
-
'javelin-install',
2091
-
'javelin-dom',
2092
-
'phuix-icon-view',
2093
-
'phabricator-prefab',
2094
2094
),
2095
2095
'fc91ab6c' => array(
2096
2096
'javelin-behavior',
+8
webroot/rsrc/js/phuix/PHUIXAutocomplete.js
+8
webroot/rsrc/js/phuix/PHUIXAutocomplete.js
···
304
304
},
305
305
306
306
_onselect: function (e) {
307
+
if (!e.isNormalMouseEvent()) {
308
+
// Eat right clicks, control clicks, etc., on the results. These can
309
+
// not do anything meaningful and if we let them through they'll blur
310
+
// the field and dismiss the results.
311
+
e.kill();
312
+
return;
313
+
}
314
+
307
315
var target = e.getNode('typeahead-result');
308
316
309
317
for (var ii = 0; ii < this._listNodes.length; ii++) {