recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHP 8.1 "strlen(null)" exception on SVN History page after changing "Import Only"

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=b325304b6e52), phorge(head=master, ref.master=cb938d869c3f)
#0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/repository/xaction/PhabricatorRepositorySVNSubpathTransaction.php:25]
```

Closes T15445

Test Plan: After applying this change, and after setting some "Import Only" value for a new Subversion repository, the page `/diffusion/1/manage/history/` renders showing `R1` being Inactive and `user set the repository "Import Only" path to main`.

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15445

Differential Revision: https://we.phorge.it/D25277

Andre Klapper 7af82abc b09471d5

+2 -2
+2 -2
src/applications/repository/xaction/PhabricatorRepositorySVNSubpathTransaction.php
··· 17 17 $old = $this->getOldValue(); 18 18 $new = $this->getNewValue(); 19 19 20 - if (!strlen($new)) { 20 + if ($new === null || !strlen($new)) { 21 21 return pht( 22 22 '%s removed %s as the "Import Only" path.', 23 23 $this->renderAuthor(), 24 24 $this->renderOldValue()); 25 - } else if (!strlen($old)) { 25 + } else if ($old === null || !$old) { 26 26 return pht( 27 27 '%s set the repository "Import Only" path to %s.', 28 28 $this->renderAuthor(),