recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Personal Flags: Require login for its UI

Summary:
Flags are personal bookmarks. They are not exposed to any other users.
That means you have to be logged in to see, store, or edit flags.

Closess T16210

Test Plan:
* Set "Can Use Application" to "Public" on http://phorge.localhost/applications/view/PhabricatorFlagsApplication/
* While being logged out,
** go to http://phorge.localhost/flag/
** go to http://phorge.localhost/flag/query/advanced/
** go to http://phorge.localhost/flag/query/all/
** set "Can Use Application" to "Public" on https://phabricator.wikimedia.org/applications/view/PhabricatorManiphestApplication/, go to http://phorge.localhost/T1 (and set the View Policy of `T1` also to Public), click "Flag For Later" in the sidebar (no change, still getting a Login dialog)
* Go to Maniphest Advanced Search and search for a task which has a flag set by some user
Do the same while being logged in: All still works.

Reviewers: O1 Blessed Committers, mainframe98, valerio.bozzolan

Reviewed By: O1 Blessed Committers, mainframe98, valerio.bozzolan

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16210

Differential Revision: https://we.phorge.it/D26259

Andre Klapper 7afe31b8 357a50e8

-4
-4
src/applications/flag/controller/PhabricatorFlagListController.php
··· 2 2 3 3 final class PhabricatorFlagListController extends PhabricatorFlagController { 4 4 5 - public function shouldAllowPublic() { 6 - return true; 7 - } 8 - 9 5 public function handleRequest(AphrontRequest $request) { 10 6 $viewer = $request->getViewer(); 11 7 $querykey = $request->getURIData('queryKey');