@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Move DifferentialRevisionViewController to newPage()
Summary: I think this works?
Test Plan:
i am wizard
{F1168808}
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D15457
+12
-10
+12
-10
src/applications/differential/controller/DifferentialRevisionViewController.php
+12
-10
src/applications/differential/controller/DifferentialRevisionViewController.php
···
481
481
->setBaseURI(new PhutilURI('/D'.$revision->getID()))
482
482
->setCollapsed((bool)$collapsed)
483
483
->build($changesets);
484
-
$nav->appendChild($content);
485
-
$nav->setCrumbs($crumbs);
486
-
$content = $nav;
487
484
} else {
488
-
array_unshift($content, $crumbs);
485
+
$nav = null;
489
486
}
490
487
491
-
return $this->buildApplicationPage(
492
-
$content,
493
-
array(
494
-
'title' => $object_id.' '.$revision->getTitle(),
495
-
'pageObjects' => array($revision->getPHID()),
496
-
));
488
+
$page = $this->newPage()
489
+
->setTitle($object_id.' '.$revision->getTitle())
490
+
->setCrumbs($crumbs)
491
+
->setPageObjectPHIDs(array($revision->getPHID()))
492
+
->appendChild($content);
493
+
494
+
if ($nav) {
495
+
$page->setNavigation($nav);
496
+
}
497
+
498
+
return $page;
497
499
}
498
500
499
501
private function getRevisionActions(DifferentialRevision $revision) {