recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Improve atomizing of PHP `@return` annotation

Summary: Fixes T6890. This doesn't feel like a perfect solution, but I can't think of any cases in which this will produce the wrong result either.

Test Plan: Ran `./bin/diviner generate` and checked the generated documentation for `PhabricatorCommonPasswords::loadWordlist()`. The return type was corrected shown as `map<string, bool>`.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6890

Differential Revision: https://secure.phabricator.com/D11469

Joshua Spence 7bd2994c 25ee2d45

+1 -1
+1 -1
src/applications/diviner/atomizer/DivinerPHPAtomizer.php
··· 293 293 'this implicitly.'); 294 294 } 295 295 } else if ($return) { 296 - $split = preg_split('/\s+/', trim($return), $limit = 2); 296 + $split = preg_split('/(?<!,)\s+/', trim($return), $limit = 2); 297 297 if (!empty($split[0])) { 298 298 $type = $split[0]; 299 299 }