@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix D2490 (make macro handler correctly bail if there are no macros)
Summary: D2490 was not my finest hour and I incorrectly thought it was a null value from error. In reality this error is impossible and its just a valid empty array so instead use the empty predicate to bail.
Test Plan: with our logic combined, this be tested
Reviewers: vrana, epriestley
Reviewed By: epriestley
CC: aran, Koolvin
Differential Revision: https://secure.phabricator.com/D2503
+2
-2
+2
-2
src/infrastructure/daemon/irc/handler/macro/PhabricatorIRCMacroHandler.php
+2
-2
src/infrastructure/daemon/irc/handler/macro/PhabricatorIRCMacroHandler.php
···
39
39
$macros = $this->getConduit()->callMethodSynchronous(
40
40
'macro.query',
41
41
array());
42
-
// gotta bail if we failed to fetch the macros
43
-
if ($macros === null) {
42
+
// bail if we have no macros
43
+
if (empty($macros)) {
44
44
return false;
45
45
}
46
46
$this->macros = $macros;