@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add more useful PHIDs to Harbormaster build variables
Summary: Ref T13609. Add the Object PHID (object being built), Container PHID (container of the object being built), Build PHID, and Buildable PHID to Harbormaster build variables.
Test Plan:
{F8448191}
{F8448192}
Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam
Maniphest Tasks: T13609
Differential Revision: https://secure.phabricator.com/D21569
+20
+20
src/applications/harbormaster/storage/build/HarbormasterBuild.php
+20
src/applications/harbormaster/storage/build/HarbormasterBuild.php
···
128
128
'step.timestamp' => null,
129
129
'build.id' => null,
130
130
'initiator.phid' => null,
131
+
132
+
'buildable.phid' => null,
133
+
'buildable.object.phid' => null,
134
+
'buildable.container.phid' => null,
135
+
'build.phid' => null,
131
136
);
132
137
133
138
foreach ($this->getBuildParameters() as $key => $value) {
···
144
149
$results['step.timestamp'] = time();
145
150
$results['build.id'] = $this->getID();
146
151
$results['initiator.phid'] = $this->getInitiatorPHID();
152
+
153
+
$results['buildable.phid'] = $buildable->getPHID();
154
+
$results['buildable.object.phid'] = $object->getPHID();
155
+
$results['buildable.container.phid'] = $buildable->getContainerPHID();
156
+
$results['build.phid'] = $this->getPHID();
147
157
148
158
return $results;
149
159
}
···
161
171
'initiator.phid' => pht(
162
172
'The PHID of the user or Object that initiated the build, '.
163
173
'if applicable.'),
174
+
'buildable.phid' => pht(
175
+
'The object PHID of the Harbormaster Buildable being built.'),
176
+
'buildable.object.phid' => pht(
177
+
'The object PHID of the object (usually a diff or commit) '.
178
+
'being built.'),
179
+
'buildable.container.phid' => pht(
180
+
'The object PHID of the container (usually a revision or repository) '.
181
+
'for the object being built.'),
182
+
'build.phid' => pht(
183
+
'The object PHID of the Harbormaster Build being built.'),
164
184
);
165
185
166
186
foreach ($objects as $object) {