Fix a Quicksand/Lightbox contention issue · recaptime.dev/phorge@7c4c76d

@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge

phorge phabricator

fork

Fix a Quicksand/Lightbox contention issue

Summary:
Fixes T11785. Lightbox calls `JX.Stratcom.pass()` to let other handlers react, but should not. At least today, we never put, e.g., links inside a lightbox.

This code appears in the original commit so it was probably just copy/pasted from somewhere and I missed it in review.

(Or there's some edge case I'm not thinking of and we'll figure it out soon enough.)

Additionally, blacklist `/file/data/` from Quicksand naviagtion: Quicksand should never fetch these URIs.

Test Plan:
- Disabled `security.alternate-file-domain`.
- Enabled Quicksand ("Persistent Chat").
- Clicked an image thumbnail on a task.
- Repeated that until things flipped out a bit.
- After the patch: no issues.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11785

Differential Revision: https://secure.phabricator.com/D16884

epriestley 9 years ago 7c4c76d3 d2f3e7f7

+8 -5

2 changed files

expand all

src

applications

files

application

PhabricatorFilesApplication.php

webroot

rsrc

core

behavior-lightbox-attachments.js

src/applications/files/application/PhabricatorFilesApplication.php

··· 129 129 ); 130 130 } 131 131 132 + public function getQuicksandURIPatternBlacklist() { 133 + return array( 134 + '/file/data/.*', 135 + ); 136 + } 137 + 132 138 }

Configure Feed

Configure Feed