recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Revert "Rename `PhabricatorPolicyRule` subclasses for consistency"

This reverts commit 8b7561776f3f5535c625b6d260811cfc51cf4b61.

See: https://secure.phabricator.com/rP8b7561776f3f5535c625b6d260811cfc51cf4b61

epriestley 7c4de0f6 a98ec20d

+22 -18
+10 -10
src/__phutil_library_map__.php
··· 1229 1229 'PhabricatorActionListView' => 'view/layout/PhabricatorActionListView.php', 1230 1230 'PhabricatorActionView' => 'view/layout/PhabricatorActionView.php', 1231 1231 'PhabricatorActivitySettingsPanel' => 'applications/settings/panel/PhabricatorActivitySettingsPanel.php', 1232 - 'PhabricatorAdministratorsPolicyRule' => 'applications/policy/rule/PhabricatorAdministratorsPolicyRule.php', 1233 1232 'PhabricatorAllCapsTranslation' => 'infrastructure/internationalization/translation/PhabricatorAllCapsTranslation.php', 1234 1233 'PhabricatorAlmanacApplication' => 'applications/almanac/application/PhabricatorAlmanacApplication.php', 1235 1234 'PhabricatorAmazonAuthProvider' => 'applications/auth/provider/PhabricatorAmazonAuthProvider.php', ··· 1854 1853 'PhabricatorLegalpadApplication' => 'applications/legalpad/application/PhabricatorLegalpadApplication.php', 1855 1854 'PhabricatorLegalpadConfigOptions' => 'applications/legalpad/config/PhabricatorLegalpadConfigOptions.php', 1856 1855 'PhabricatorLegalpadDocumentPHIDType' => 'applications/legalpad/phid/PhabricatorLegalpadDocumentPHIDType.php', 1857 - 'PhabricatorLegalpadSignaturePolicyRule' => 'applications/policy/rule/PhabricatorLegalpadSignaturePolicyRule.php', 1858 1856 'PhabricatorLipsumArtist' => 'applications/lipsum/image/PhabricatorLipsumArtist.php', 1859 1857 'PhabricatorLipsumGenerateWorkflow' => 'applications/lipsum/management/PhabricatorLipsumGenerateWorkflow.php', 1860 1858 'PhabricatorLipsumManagementWorkflow' => 'applications/lipsum/management/PhabricatorLipsumManagementWorkflow.php', ··· 1864 1862 'PhabricatorLocalDiskFileStorageEngine' => 'applications/files/engine/PhabricatorLocalDiskFileStorageEngine.php', 1865 1863 'PhabricatorLocalTimeTestCase' => 'view/__tests__/PhabricatorLocalTimeTestCase.php', 1866 1864 'PhabricatorLogoutController' => 'applications/auth/controller/PhabricatorLogoutController.php', 1867 - 'PhabricatorLunarPhasePolicyRule' => 'applications/policy/rule/PhabricatorLunarPhasePolicyRule.php', 1868 1865 'PhabricatorMacroApplication' => 'applications/macro/application/PhabricatorMacroApplication.php', 1869 1866 'PhabricatorMacroAudioController' => 'applications/macro/controller/PhabricatorMacroAudioController.php', 1870 1867 'PhabricatorMacroCommentController' => 'applications/macro/controller/PhabricatorMacroCommentController.php', ··· 2144 2141 'PhabricatorPolicyPHIDTypePolicy' => 'applications/policy/phid/PhabricatorPolicyPHIDTypePolicy.php', 2145 2142 'PhabricatorPolicyQuery' => 'applications/policy/query/PhabricatorPolicyQuery.php', 2146 2143 'PhabricatorPolicyRule' => 'applications/policy/rule/PhabricatorPolicyRule.php', 2144 + 'PhabricatorPolicyRuleAdministrators' => 'applications/policy/rule/PhabricatorPolicyRuleAdministrators.php', 2145 + 'PhabricatorPolicyRuleLegalpadSignature' => 'applications/policy/rule/PhabricatorPolicyRuleLegalpadSignature.php', 2146 + 'PhabricatorPolicyRuleLunarPhase' => 'applications/policy/rule/PhabricatorPolicyRuleLunarPhase.php', 2147 + 'PhabricatorPolicyRuleProjects' => 'applications/policy/rule/PhabricatorPolicyRuleProjects.php', 2148 + 'PhabricatorPolicyRuleUsers' => 'applications/policy/rule/PhabricatorPolicyRuleUsers.php', 2147 2149 'PhabricatorPolicyTestCase' => 'applications/policy/__tests__/PhabricatorPolicyTestCase.php', 2148 2150 'PhabricatorPolicyTestObject' => 'applications/policy/__tests__/PhabricatorPolicyTestObject.php', 2149 2151 'PhabricatorPolicyType' => 'applications/policy/constants/PhabricatorPolicyType.php', ··· 2210 2212 'PhabricatorProjectUpdateController' => 'applications/project/controller/PhabricatorProjectUpdateController.php', 2211 2213 'PhabricatorProjectWatchController' => 'applications/project/controller/PhabricatorProjectWatchController.php', 2212 2214 'PhabricatorProjectWikiExplainController' => 'applications/project/controller/PhabricatorProjectWikiExplainController.php', 2213 - 'PhabricatorProjectsPolicyRule' => 'applications/policy/rule/PhabricatorProjectsPolicyRule.php', 2214 2215 'PhabricatorPygmentSetupCheck' => 'applications/config/check/PhabricatorPygmentSetupCheck.php', 2215 2216 'PhabricatorQuery' => 'infrastructure/query/PhabricatorQuery.php', 2216 2217 'PhabricatorRecaptchaConfigOptions' => 'applications/config/option/PhabricatorRecaptchaConfigOptions.php', ··· 2542 2543 'PhabricatorUserTestCase' => 'applications/people/storage/__tests__/PhabricatorUserTestCase.php', 2543 2544 'PhabricatorUserTitleField' => 'applications/people/customfield/PhabricatorUserTitleField.php', 2544 2545 'PhabricatorUserTransaction' => 'applications/people/storage/PhabricatorUserTransaction.php', 2545 - 'PhabricatorUsersPolicyRule' => 'applications/policy/rule/PhabricatorUsersPolicyRule.php', 2546 2546 'PhabricatorVCSResponse' => 'applications/repository/response/PhabricatorVCSResponse.php', 2547 2547 'PhabricatorWordPressAuthProvider' => 'applications/auth/provider/PhabricatorWordPressAuthProvider.php', 2548 2548 'PhabricatorWorker' => 'infrastructure/daemon/workers/PhabricatorWorker.php', ··· 4366 4366 'PhabricatorActionListView' => 'AphrontView', 4367 4367 'PhabricatorActionView' => 'AphrontView', 4368 4368 'PhabricatorActivitySettingsPanel' => 'PhabricatorSettingsPanel', 4369 - 'PhabricatorAdministratorsPolicyRule' => 'PhabricatorPolicyRule', 4370 4369 'PhabricatorAllCapsTranslation' => 'PhabricatorTranslation', 4371 4370 'PhabricatorAlmanacApplication' => 'PhabricatorApplication', 4372 4371 'PhabricatorAmazonAuthProvider' => 'PhabricatorOAuth2AuthProvider', ··· 5037 5036 'PhabricatorLegalpadApplication' => 'PhabricatorApplication', 5038 5037 'PhabricatorLegalpadConfigOptions' => 'PhabricatorApplicationConfigOptions', 5039 5038 'PhabricatorLegalpadDocumentPHIDType' => 'PhabricatorPHIDType', 5040 - 'PhabricatorLegalpadSignaturePolicyRule' => 'PhabricatorPolicyRule', 5041 5039 'PhabricatorLipsumGenerateWorkflow' => 'PhabricatorLipsumManagementWorkflow', 5042 5040 'PhabricatorLipsumManagementWorkflow' => 'PhabricatorManagementWorkflow', 5043 5041 'PhabricatorLipsumMondrianArtist' => 'PhabricatorLipsumArtist', ··· 5045 5043 'PhabricatorLocalDiskFileStorageEngine' => 'PhabricatorFileStorageEngine', 5046 5044 'PhabricatorLocalTimeTestCase' => 'PhabricatorTestCase', 5047 5045 'PhabricatorLogoutController' => 'PhabricatorAuthController', 5048 - 'PhabricatorLunarPhasePolicyRule' => 'PhabricatorPolicyRule', 5049 5046 'PhabricatorMacroApplication' => 'PhabricatorApplication', 5050 5047 'PhabricatorMacroAudioController' => 'PhabricatorMacroController', 5051 5048 'PhabricatorMacroCommentController' => 'PhabricatorMacroController', ··· 5325 5322 'PhabricatorPolicyManagementWorkflow' => 'PhabricatorManagementWorkflow', 5326 5323 'PhabricatorPolicyPHIDTypePolicy' => 'PhabricatorPHIDType', 5327 5324 'PhabricatorPolicyQuery' => 'PhabricatorCursorPagedPolicyAwareQuery', 5325 + 'PhabricatorPolicyRuleAdministrators' => 'PhabricatorPolicyRule', 5326 + 'PhabricatorPolicyRuleLegalpadSignature' => 'PhabricatorPolicyRule', 5327 + 'PhabricatorPolicyRuleLunarPhase' => 'PhabricatorPolicyRule', 5328 + 'PhabricatorPolicyRuleProjects' => 'PhabricatorPolicyRule', 5329 + 'PhabricatorPolicyRuleUsers' => 'PhabricatorPolicyRule', 5328 5330 'PhabricatorPolicyTestCase' => 'PhabricatorTestCase', 5329 5331 'PhabricatorPolicyTestObject' => 'PhabricatorPolicyInterface', 5330 5332 'PhabricatorPolicyType' => 'PhabricatorPolicyConstants', ··· 5411 5413 'PhabricatorProjectUpdateController' => 'PhabricatorProjectController', 5412 5414 'PhabricatorProjectWatchController' => 'PhabricatorProjectController', 5413 5415 'PhabricatorProjectWikiExplainController' => 'PhabricatorProjectController', 5414 - 'PhabricatorProjectsPolicyRule' => 'PhabricatorPolicyRule', 5415 5416 'PhabricatorPygmentSetupCheck' => 'PhabricatorSetupCheck', 5416 5417 'PhabricatorRecaptchaConfigOptions' => 'PhabricatorApplicationConfigOptions', 5417 5418 'PhabricatorRedirectController' => 'PhabricatorController', ··· 5777 5778 'PhabricatorUserTestCase' => 'PhabricatorTestCase', 5778 5779 'PhabricatorUserTitleField' => 'PhabricatorUserCustomField', 5779 5780 'PhabricatorUserTransaction' => 'PhabricatorApplicationTransaction', 5780 - 'PhabricatorUsersPolicyRule' => 'PhabricatorPolicyRule', 5781 5781 'PhabricatorVCSResponse' => 'AphrontResponse', 5782 5782 'PhabricatorWordPressAuthProvider' => 'PhabricatorOAuth2AuthProvider', 5783 5783 'PhabricatorWorkerActiveTask' => 'PhabricatorWorkerTask',
+3 -3
src/applications/policy/__tests__/PhabricatorPolicyDataTestCase.php
··· 48 48 array( 49 49 array( 50 50 'action' => PhabricatorPolicy::ACTION_ALLOW, 51 - 'rule' => 'PhabricatorUsersPolicyRule', 51 + 'rule' => 'PhabricatorPolicyRuleUsers', 52 52 'value' => array($user_a->getPHID()), 53 53 ), 54 54 )) ··· 84 84 array( 85 85 array( 86 86 'action' => PhabricatorPolicy::ACTION_ALLOW, 87 - 'rule' => 'PhabricatorAdministratorsPolicyRule', 87 + 'rule' => 'PhabricatorPolicyRuleAdministrators', 88 88 'value' => null, 89 89 ), 90 90 )) ··· 118 118 array( 119 119 array( 120 120 'action' => PhabricatorPolicy::ACTION_ALLOW, 121 - 'rule' => 'PhabricatorLunarPhasePolicyRule', 121 + 'rule' => 'PhabricatorPolicyRuleLunarPhase', 122 122 'value' => 'new', 123 123 ), 124 124 ))
+2 -1
src/applications/policy/rule/PhabricatorAdministratorsPolicyRule.php src/applications/policy/rule/PhabricatorPolicyRuleAdministrators.php
··· 1 1 <?php 2 2 3 - final class PhabricatorAdministratorsPolicyRule extends PhabricatorPolicyRule { 3 + final class PhabricatorPolicyRuleAdministrators 4 + extends PhabricatorPolicyRule { 4 5 5 6 public function getRuleDescription() { 6 7 return pht('administrators');
+1 -1
src/applications/policy/rule/PhabricatorLegalpadSignaturePolicyRule.php src/applications/policy/rule/PhabricatorPolicyRuleLegalpadSignature.php
··· 1 1 <?php 2 2 3 - final class PhabricatorLegalpadSignaturePolicyRule 3 + final class PhabricatorPolicyRuleLegalpadSignature 4 4 extends PhabricatorPolicyRule { 5 5 6 6 private $signatures = array();
+2 -1
src/applications/policy/rule/PhabricatorLunarPhasePolicyRule.php src/applications/policy/rule/PhabricatorPolicyRuleLunarPhase.php
··· 1 1 <?php 2 2 3 - final class PhabricatorLunarPhasePolicyRule extends PhabricatorPolicyRule { 3 + final class PhabricatorPolicyRuleLunarPhase 4 + extends PhabricatorPolicyRule { 4 5 5 6 const PHASE_FULL = 'full'; 6 7 const PHASE_NEW = 'new';
+2 -1
src/applications/policy/rule/PhabricatorProjectsPolicyRule.php src/applications/policy/rule/PhabricatorPolicyRuleProjects.php
··· 1 1 <?php 2 2 3 - final class PhabricatorProjectsPolicyRule extends PhabricatorPolicyRule { 3 + final class PhabricatorPolicyRuleProjects 4 + extends PhabricatorPolicyRule { 4 5 5 6 private $memberships = array(); 6 7
+2 -1
src/applications/policy/rule/PhabricatorUsersPolicyRule.php src/applications/policy/rule/PhabricatorPolicyRuleUsers.php
··· 1 1 <?php 2 2 3 - final class PhabricatorUsersPolicyRule extends PhabricatorPolicyRule { 3 + final class PhabricatorPolicyRuleUsers 4 + extends PhabricatorPolicyRule { 4 5 5 6 public function getRuleDescription() { 6 7 return pht('users');