@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Let omnipotent actors skip MFA transactions
Summary: This seems generally reasonable, but is also a narrow fix to "Phacility scripts try to move instances into 'up', but the daemons can't MFA".
Test Plan: Launched a new instance locally, no more "daemons can't MFA" error.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20081
+7
-2
+7
-2
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+7
-2
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
4856
4856
}
4857
4857
4858
4858
private function requireMFA(PhabricatorLiskDAO $object, array $xactions) {
4859
+
$actor = $this->getActor();
4860
+
4861
+
// Let omnipotent editors skip MFA. This is mostly aimed at scripts.
4862
+
if ($actor->isOmnipotent()) {
4863
+
return;
4864
+
}
4865
+
4859
4866
$editor_class = get_class($this);
4860
4867
4861
4868
$object_phid = $object->getPHID();
···
4869
4876
'editor(%s).new()',
4870
4877
$editor_class);
4871
4878
}
4872
-
4873
-
$actor = $this->getActor();
4874
4879
4875
4880
$request = $this->getRequest();
4876
4881
if ($request === null) {