@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove badge support from PHUIHeaderView

Summary: These are now unused.

Test Plan: grep, remove uiexamples

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D18090

authored by

Chad Little and committed by
chad
7c955d79 0700bb2a

+8 -49
+3 -3
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => 'ff161f2d', 11 11 'conpherence.pkg.js' => 'b5b51108', 12 - 'core.pkg.css' => '7e4901ea', 12 + 'core.pkg.css' => 'ab24402f', 13 13 'core.pkg.js' => '1475bd91', 14 14 'darkconsole.pkg.js' => '1f9a31bc', 15 15 'differential.pkg.css' => '1ccbf3a9', ··· 157 157 'rsrc/css/phui/phui-form-view.css' => '6175808d', 158 158 'rsrc/css/phui/phui-form.css' => 'a5570f70', 159 159 'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f', 160 - 'rsrc/css/phui/phui-header-view.css' => '73edce66', 160 + 'rsrc/css/phui/phui-header-view.css' => 'e7de7ee2', 161 161 'rsrc/css/phui/phui-hovercard.css' => 'f0592bcf', 162 162 'rsrc/css/phui/phui-icon-set-selector.css' => '87db8fee', 163 163 'rsrc/css/phui/phui-icon.css' => '4c46b6ba', ··· 843 843 'phui-form-css' => 'a5570f70', 844 844 'phui-form-view-css' => '6175808d', 845 845 'phui-head-thing-view-css' => 'fd311e5f', 846 - 'phui-header-view-css' => '73edce66', 846 + 'phui-header-view-css' => 'e7de7ee2', 847 847 'phui-hovercard' => '1bd28176', 848 848 'phui-hovercard-view-css' => 'f0592bcf', 849 849 'phui-icon-set-selector-css' => '87db8fee',
+4 -13
src/applications/uiexample/examples/PHUIBoxExample.php
··· 68 68 ->setText(pht('Such Wow')) 69 69 ->addClass(PHUI::MARGIN_SMALL_RIGHT); 70 70 71 - $badge1 = id(new PHUIBadgeMiniView()) 72 - ->setIcon('fa-bug') 73 - ->setHeader(pht('Bugmeister')); 74 - 75 - $badge2 = id(new PHUIBadgeMiniView()) 76 - ->setIcon('fa-heart') 77 - ->setHeader(pht('Funder')) 78 - ->setQuality(PhabricatorBadgesQuality::UNCOMMON); 79 - 80 71 $header = id(new PHUIHeaderView()) 81 72 ->setHeader(pht('Fancy Box')) 82 73 ->addActionLink($button) 83 - ->setSubheader(pht('Much Features')) 84 - ->addBadge($badge1) 85 - ->addBadge($badge2); 74 + ->setSubheader(pht('Much Features')); 86 75 87 76 $obj4 = id(new PHUIObjectBoxView()) 88 77 ->setHeader($header) ··· 116 105 117 106 return phutil_tag( 118 107 'div', 119 - array(), 108 + array( 109 + 'class' => 'ml', 110 + ), 120 111 array( 121 112 $head1, 122 113 $wrap1,
-10
src/applications/uiexample/examples/PHUIHovercardUIExample.php
··· 55 55 ->addTag($tag)); 56 56 $elements[] = $panel; 57 57 58 - $badge1 = id(new PHUIBadgeMiniView()) 59 - ->setIcon('fa-book') 60 - ->setHeader(pht('Documenter')); 61 - 62 - $badge2 = id(new PHUIBadgeMiniView()) 63 - ->setIcon('fa-star') 64 - ->setHeader(pht('Contributor')); 65 - 66 58 $user_handle = $this->createBasicDummyHandle( 67 59 'gwashington', 68 60 PhabricatorPeopleUserPHIDType::TYPECONST, ··· 75 67 ->addField(pht('Status'), pht('Available')) 76 68 ->addField(pht('Member since'), '30. February 1750') 77 69 ->addAction(pht('Send a Message'), '/dev/null') 78 - ->addBadge($badge1) 79 - ->addBadge($badge2) 80 70 ->setUser($user)); 81 71 $elements[] = $panel; 82 72
+1 -15
src/view/phui/PHUIHeaderView.php
··· 21 21 private $policyObject; 22 22 private $epoch; 23 23 private $actionItems = array(); 24 - private $badges = array(); 25 24 private $href; 26 25 private $actionList; 27 26 private $actionListID; ··· 43 42 44 43 public function addTag(PHUITagView $tag) { 45 44 $this->tags[] = $tag; 46 - return $this; 47 - } 48 - 49 - public function addBadge(PHUIBadgeMiniView $badge) { 50 - $this->badges[] = $badge; 51 45 return $this; 52 46 } 53 47 ··· 341 335 $header_content, 342 336 )); 343 337 344 - if ($this->subheader || $this->badges) { 345 - $badges = null; 346 - if ($this->badges) { 347 - $badges = new PHUIBadgeBoxView(); 348 - $badges->addItems($this->badges); 349 - $badges->setCollapsed(true); 350 - } 351 - 338 + if ($this->subheader) { 352 339 $left[] = phutil_tag( 353 340 'div', 354 341 array( 355 342 'class' => 'phui-header-subheader', 356 343 ), 357 344 array( 358 - $badges, 359 345 $this->subheader, 360 346 )); 361 347 }
-8
webroot/rsrc/css/phui/phui-header-view.css
··· 307 307 text-decoration: underline; 308 308 } 309 309 310 - .phui-header-subheader .phui-badge-flex-view { 311 - display: inline; 312 - margin-right: 4px; 313 - } 314 - 315 - .phui-header-subheader .phui-badge-flex-view:after { 316 - display: inline; 317 - } 318 310 319 311 /*** Profile Header ***********************************************************/ 320 312