@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make ghost event instances render better on the event list
Summary:
Ref T11326. Currently, we render "E (99)" for ghost instances, which is meaningless and inconsistent.
Render these more sensibly and consistently.
Test Plan: Viewed event list, saw reasonable monograms / object names.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11326
Differential Revision: https://secure.phabricator.com/D16296
+6
-7
+6
-7
src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
+6
-7
src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
···
275
275
}
276
276
277
277
if ($event->getIsGhostEvent()) {
278
-
$title_text = $event->getMonogram()
279
-
.' ('
280
-
.$event->getSequenceIndex()
281
-
.'): '
282
-
.$event->getName();
278
+
$monogram = $event->getParentEvent()->getMonogram();
279
+
$index = $event->getSequenceIndex();
280
+
$monogram = "{$monogram}/{$index}";
283
281
} else {
284
-
$title_text = $event->getMonogram().': '.$event->getName();
282
+
$monogram = $event->getMonogram();
285
283
}
286
284
287
285
$item = id(new PHUIObjectItemView())
288
286
->setUser($viewer)
289
287
->setObject($event)
290
-
->setHeader($title_text)
288
+
->setObjectName($monogram)
289
+
->setHeader($event->getName())
291
290
->setHref($event->getURI())
292
291
->addAttribute($event_date_info);
293
292