@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix autocomplete in input forms
Summary:
The changes in D26494 broke autocomplete for all object types
besides users (like projects, wiki links, etc.).
Test Plan:
Go to an input field (e.g., comment field), try various
autocompletes. like hash, colon, etc. Also verify that
involved users still works (go to a task and check
sort order of user suggestions after typing @).
Reviewers: aklapper, O1 Blessed Committers
Reviewed By: aklapper, O1 Blessed Committers
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D26681
+10
-10
+9
-9
resources/celerity/map.php
+9
-9
resources/celerity/map.php
···
10
10
'conpherence.pkg.css' => 'b2d6f4b8',
11
11
'conpherence.pkg.js' => '020aebcf',
12
12
'core.pkg.css' => '671fbe41',
13
-
'core.pkg.js' => '33424d18',
13
+
'core.pkg.js' => '3b8563ac',
14
14
'dark-console.pkg.js' => '187792c2',
15
15
'differential.pkg.css' => 'abdb4fe9',
16
16
'differential.pkg.js' => '46fcb3af',
···
456
456
'rsrc/js/phui/behavior-phui-timer-control.js' => 'f84bcbf4',
457
457
'rsrc/js/phuix/PHUIXActionListView.js' => 'c68f183f',
458
458
'rsrc/js/phuix/PHUIXActionView.js' => 'a8f573a9',
459
-
'rsrc/js/phuix/PHUIXAutocomplete.js' => 'ce2a0c3e',
459
+
'rsrc/js/phuix/PHUIXAutocomplete.js' => '7477f763',
460
460
'rsrc/js/phuix/PHUIXButtonView.js' => '55a24e84',
461
461
'rsrc/js/phuix/PHUIXDropdownMenu.js' => 'b557770a',
462
462
'rsrc/js/phuix/PHUIXExample.js' => 'c2c500a7',
···
816
816
'phui-workpanel-view-css' => 'c44f95c7',
817
817
'phuix-action-list-view' => 'c68f183f',
818
818
'phuix-action-view' => 'a8f573a9',
819
-
'phuix-autocomplete' => 'ce2a0c3e',
819
+
'phuix-autocomplete' => '7477f763',
820
820
'phuix-button-view' => '55a24e84',
821
821
'phuix-dropdown-menu' => 'b557770a',
822
822
'phuix-form-control-view' => '38c1f3fb',
···
1507
1507
'phabricator-drag-and-drop-file-upload',
1508
1508
'javelin-workboard-board',
1509
1509
),
1510
+
'7477f763' => array(
1511
+
'javelin-install',
1512
+
'javelin-dom',
1513
+
'phuix-icon-view',
1514
+
'phabricator-prefab',
1515
+
),
1510
1516
'78bc5d94' => array(
1511
1517
'javelin-behavior',
1512
1518
'javelin-uri',
···
1967
1973
'javelin-install',
1968
1974
'phuix-button-view',
1969
1975
'phabricator-diff-tree-view',
1970
-
),
1971
-
'ce2a0c3e' => array(
1972
-
'javelin-install',
1973
-
'javelin-dom',
1974
-
'phuix-icon-view',
1975
-
'phabricator-prefab',
1976
1976
),
1977
1977
'ce6f8e3d' => array(
1978
1978
'phui-chart-css',
+1
-1
webroot/rsrc/js/phuix/PHUIXAutocomplete.js
+1
-1
webroot/rsrc/js/phuix/PHUIXAutocomplete.js
···
158
158
159
159
datasource.setTransformer(JX.bind(this, this._transformresult));
160
160
// List users first who are involved in the object
161
-
var involvedUsers = spec.involvedUsers;
161
+
var involvedUsers = 'involvedUsers' in spec ? spec.involvedUsers : null;
162
162
if (involvedUsers !== null && involvedUsers.length !== 0) {
163
163
datasource.setSortHandler(function(value, list) {
164
164
list.sort(function(u,v){