-2

conf/default.conf.php

reviewed

··· 794 794 '/\.l?hs$/', 795 795 ), 796 796 797 797 - 'differential.field-selector' => 'DifferentialDefaultFieldSelector', 798 798 - 799 797 // Differential has a required "Test Plan" field by default. You can make it 800 798 // optional by setting this to false. You can also completely remove it above, 801 799 // if you prefer.

-3

src/__phutil_library_map__.php

reviewed

··· 375 375 'DifferentialDAO' => 'applications/differential/storage/DifferentialDAO.php', 376 376 'DifferentialDateCreatedFieldSpecification' => 'applications/differential/field/specification/DifferentialDateCreatedFieldSpecification.php', 377 377 'DifferentialDateModifiedFieldSpecification' => 'applications/differential/field/specification/DifferentialDateModifiedFieldSpecification.php', 378 378 - 'DifferentialDefaultFieldSelector' => 'applications/differential/field/selector/DifferentialDefaultFieldSelector.php', 379 378 'DifferentialDependenciesField' => 'applications/differential/customfield/DifferentialDependenciesField.php', 380 379 'DifferentialDependenciesFieldSpecification' => 'applications/differential/field/specification/DifferentialDependenciesFieldSpecification.php', 381 380 'DifferentialDependsOnField' => 'applications/differential/customfield/DifferentialDependsOnField.php', ··· 397 396 'DifferentialExportPatchFieldSpecification' => 'applications/differential/field/specification/DifferentialExportPatchFieldSpecification.php', 398 397 'DifferentialFieldDataNotAvailableException' => 'applications/differential/field/exception/DifferentialFieldDataNotAvailableException.php', 399 398 'DifferentialFieldParseException' => 'applications/differential/field/exception/DifferentialFieldParseException.php', 400 400 - 'DifferentialFieldSelector' => 'applications/differential/field/selector/DifferentialFieldSelector.php', 401 399 'DifferentialFieldSpecification' => 'applications/differential/field/specification/DifferentialFieldSpecification.php', 402 400 'DifferentialFieldSpecificationIncompleteException' => 'applications/differential/field/exception/DifferentialFieldSpecificationIncompleteException.php', 403 401 'DifferentialFieldValidationException' => 'applications/differential/field/exception/DifferentialFieldValidationException.php', ··· 2941 2939 'DifferentialDAO' => 'PhabricatorLiskDAO', 2942 2940 'DifferentialDateCreatedFieldSpecification' => 'DifferentialFieldSpecification', 2943 2941 'DifferentialDateModifiedFieldSpecification' => 'DifferentialFieldSpecification', 2944 2944 - 'DifferentialDefaultFieldSelector' => 'DifferentialFieldSelector', 2945 2942 'DifferentialDependenciesField' => 'DifferentialCustomField', 2946 2943 'DifferentialDependenciesFieldSpecification' => 'DifferentialFieldSpecification', 2947 2944 'DifferentialDependsOnField' => 'DifferentialCustomField',

+1

src/applications/config/check/PhabricatorSetupCheckExtraConfig.php

reviewed

··· 189 189 'Obsolete; use standard rendering events instead.'), 190 190 'differential.show-host-field' => $differential_field_reason, 191 191 'differential.show-test-plan-field' => $differential_field_reason, 192 192 + 'differential.field-selector' => $differential_field_reason, 192 193 ); 193 194 194 195 return $ancient_config;

-6

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

reviewed

··· 77 77 pht( 78 78 "List of file regexps where whitespace is meaningful and should ". 79 79 "not use 'ignore-all' by default")), 80 80 - $this->newOption( 81 81 - 'differential.field-selector', 82 82 - 'class', 83 83 - 'DifferentialDefaultFieldSelector') 84 84 - ->setBaseClass('DifferentialFieldSelector') 85 85 - ->setDescription(pht('Field selector class')), 86 80 $this->newOption('differential.require-test-plan-field', 'bool', true) 87 81 ->setBoolOptions( 88 82 array(

-95

src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php

reviewed

··· 1 1 - <?php 2 2 - 3 3 - final class DifferentialDefaultFieldSelector 4 4 - extends DifferentialFieldSelector { 5 5 - 6 6 - public function getFieldSpecifications() { 7 7 - $fields = array( 8 8 - new DifferentialTitleFieldSpecification(), 9 9 - new DifferentialSummaryFieldSpecification(), 10 10 - new DifferentialTestPlanFieldSpecification(), 11 11 - new DifferentialRevisionStatusFieldSpecification(), 12 12 - new DifferentialAuthorFieldSpecification(), 13 13 - new DifferentialReviewersFieldSpecification(), 14 14 - new DifferentialProjectReviewersFieldSpecification(), 15 15 - new DifferentialReviewedByFieldSpecification(), 16 16 - new DifferentialCCsFieldSpecification(), 17 17 - new DifferentialRepositoryFieldSpecification(), 18 18 - new DifferentialViewPolicyFieldSpecification(), 19 19 - new DifferentialEditPolicyFieldSpecification(), 20 20 - new DifferentialLintFieldSpecification(), 21 21 - new DifferentialUnitFieldSpecification(), 22 22 - new DifferentialCommitsFieldSpecification(), 23 23 - new DifferentialDependsOnFieldSpecification(), 24 24 - new DifferentialDependenciesFieldSpecification(), 25 25 - new DifferentialManiphestTasksFieldSpecification(), 26 26 - new DifferentialHostFieldSpecification(), 27 27 - new DifferentialPathFieldSpecification(), 28 28 - new DifferentialBranchFieldSpecification(), 29 29 - new DifferentialArcanistProjectFieldSpecification(), 30 30 - new DifferentialApplyPatchFieldSpecification(), 31 31 - new DifferentialRevisionIDFieldSpecification(), 32 32 - new DifferentialGitSVNIDFieldSpecification(), 33 33 - new DifferentialConflictsFieldSpecification(), 34 34 - new DifferentialDateModifiedFieldSpecification(), 35 35 - new DifferentialDateCreatedFieldSpecification(), 36 36 - new DifferentialAuditorsFieldSpecification(), 37 37 - new DifferentialDiffViewPolicyFieldSpecification(), 38 38 - new DifferentialAsanaRepresentationFieldSpecification(), 39 39 - ); 40 40 - 41 41 - if (PhabricatorAuthProviderOAuth1JIRA::getJIRAProvider()) { 42 42 - $fields[] = new DifferentialJIRAIssuesFieldSpecification(); 43 43 - } 44 44 - 45 45 - return $fields; 46 46 - } 47 47 - 48 48 - public function sortFieldsForRevisionList(array $fields) { 49 49 - assert_instances_of($fields, 'DifferentialFieldSpecification'); 50 50 - 51 51 - $map = array(); 52 52 - foreach ($fields as $field) { 53 53 - $map[get_class($field)] = $field; 54 54 - } 55 55 - 56 56 - $map = array_select_keys( 57 57 - $map, 58 58 - array( 59 59 - 'DifferentialRevisionIDFieldSpecification', 60 60 - 'DifferentialTitleFieldSpecification', 61 61 - 'DifferentialRevisionStatusFieldSpecification', 62 62 - 'DifferentialAuthorFieldSpecification', 63 63 - 'DifferentialReviewersFieldSpecification', 64 64 - 'DifferentialDateModifiedFieldSpecification', 65 65 - 'DifferentialDateCreatedFieldSpecification', 66 66 - )) + $map; 67 67 - 68 68 - return array_values($map); 69 69 - } 70 70 - 71 71 - public function sortFieldsForMail(array $fields) { 72 72 - assert_instances_of($fields, 'DifferentialFieldSpecification'); 73 73 - 74 74 - $map = array(); 75 75 - foreach ($fields as $field) { 76 76 - $map[get_class($field)] = $field; 77 77 - } 78 78 - 79 79 - $map = array_select_keys( 80 80 - $map, 81 81 - array( 82 82 - 'DifferentialReviewersFieldSpecification', 83 83 - 'DifferentialSummaryFieldSpecification', 84 84 - 'DifferentialTestPlanFieldSpecification', 85 85 - 'DifferentialRevisionIDFieldSpecification', 86 86 - 'DifferentialManiphestTasksFieldSpecification', 87 87 - 'DifferentialBranchFieldSpecification', 88 88 - 'DifferentialArcanistProjectFieldSpecification', 89 89 - 'DifferentialCommitsFieldSpecification', 90 90 - )) + $map; 91 91 - 92 92 - return array_values($map); 93 93 - } 94 94 - 95 95 - }

-25

src/applications/differential/field/selector/DifferentialFieldSelector.php

reviewed

··· 1 1 - <?php 2 2 - 3 3 - abstract class DifferentialFieldSelector { 4 4 - 5 5 - final public function __construct() { 6 6 - // <empty> 7 7 - } 8 8 - 9 9 - final public static function newSelector() { 10 10 - return PhabricatorEnv::newObjectFromConfig('differential.field-selector'); 11 11 - } 12 12 - 13 13 - abstract public function getFieldSpecifications(); 14 14 - 15 15 - public function sortFieldsForRevisionList(array $fields) { 16 16 - assert_instances_of($fields, 'DifferentialFieldSpecification'); 17 17 - return $fields; 18 18 - } 19 19 - 20 20 - public function sortFieldsForMail(array $fields) { 21 21 - assert_instances_of($fields, 'DifferentialFieldSpecification'); 22 22 - return $fields; 23 23 - } 24 24 - 25 25 - }