@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix fatal in XHProf
Summary: derp, fixed method call
Test Plan: Looked up PHUIHeaderView, checked method.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D11815
+5
-8
+5
-8
src/applications/xhprof/view/PhabricatorXHProfProfileTopLevelView.php
+5
-8
src/applications/xhprof/view/PhabricatorXHProfProfileTopLevelView.php
···
123
123
124
124
$panel = new PHUIObjectBoxView();
125
125
$header = id(new PHUIHeaderView())
126
-
->setHeaderText(pht('XHProf Profile'));
126
+
->setHeader(pht('XHProf Profile'));
127
127
128
128
if ($this->file) {
129
-
$button = phutil_tag(
130
-
'a',
131
-
array(
132
-
'href' => $this->file->getBestURI(),
133
-
'class' => 'green button',
134
-
),
135
-
pht('Download .xhprof Profile'));
129
+
$button = id(new PHUIButtonView())
130
+
->setHref($this->file->getBestURI())
131
+
->setText(pht('Download .xhprof Profile'))
132
+
->setTag('a');
136
133
$header->addActionLink($button);
137
134
}
138
135