@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Restore "[Action]" mail subject lines to Differential/Diffusion

Summary: Ref T11114. Ref T10978. These hadn't made it over to EditEngine yet.

Test Plan:
- Took various actions on revisions and commits.
- Used `bin/mail show-outbound --id ...` to examine the "Vary Subject", saw it properly generate "[Accepted]", "[Resigned]", etc.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114, T10978

Differential Revision: https://secure.phabricator.com/D17191

+82
+4
src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php
··· 26 26 return 500; 27 27 } 28 28 29 + public function getActionName() { 30 + return pht('Abandoned'); 31 + } 32 + 29 33 public function getCommandKeyword() { 30 34 return 'abandon'; 31 35 }
+4
src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php
··· 26 26 return 500; 27 27 } 28 28 29 + public function getActionName() { 30 + return pht('Accepted'); 31 + } 32 + 29 33 public function getCommandKeyword() { 30 34 $accept_key = 'differential.enable-email-accept'; 31 35 $allow_email_accept = PhabricatorEnv::getEnvConfig($accept_key);
+4
src/applications/differential/xaction/DifferentialRevisionActionTransaction.php
··· 35 35 return 1000; 36 36 } 37 37 38 + public function getActionStrength() { 39 + return 3; 40 + } 41 + 38 42 public function getRevisionActionOrderVector() { 39 43 return id(new PhutilSortVector()) 40 44 ->addInt($this->getRevisionActionOrder());
+4
src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
··· 26 26 return 300; 27 27 } 28 28 29 + public function getActionName() { 30 + return pht('Closed'); 31 + } 32 + 29 33 public function generateOldValue($object) { 30 34 return $object->isClosed(); 31 35 }
+4
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
··· 26 26 return 700; 27 27 } 28 28 29 + public function getActionName() { 30 + return pht('Commandeered'); 31 + } 32 + 29 33 public function getCommandKeyword() { 30 34 return 'commandeer'; 31 35 }
+4
src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
··· 27 27 return 200; 28 28 } 29 29 30 + public function getActionName() { 31 + return pht('Planned Changes'); 32 + } 33 + 30 34 public function getCommandKeyword() { 31 35 return 'planchanges'; 32 36 }
+4
src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php
··· 26 26 return 600; 27 27 } 28 28 29 + public function getActionName() { 30 + return pht('Reclaimed'); 31 + } 32 + 29 33 public function getCommandKeyword() { 30 34 return 'reclaim'; 31 35 }
+4
src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php
··· 26 26 return 600; 27 27 } 28 28 29 + public function getActionName() { 30 + return pht('Requested Changes'); 31 + } 32 + 29 33 public function getCommandKeyword() { 30 34 return 'request'; 31 35 }
+4
src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php
··· 26 26 return 400; 27 27 } 28 28 29 + public function getActionName() { 30 + return pht('Reopened'); 31 + } 32 + 29 33 public function generateOldValue($object) { 30 34 return !$object->isClosed(); 31 35 }
+4
src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php
··· 22 22 return 200; 23 23 } 24 24 25 + public function getActionName() { 26 + return pht('Requested Review'); 27 + } 28 + 25 29 public function generateOldValue($object) { 26 30 $status_review = ArcanistDifferentialRevisionStatus::NEEDS_REVIEW; 27 31 return ($object->getStatus() == $status_review);
+4
src/applications/differential/xaction/DifferentialRevisionResignTransaction.php
··· 30 30 return 'resign'; 31 31 } 32 32 33 + public function getActionName() { 34 + return pht('Resigned'); 35 + } 36 + 33 37 public function getCommandAliases() { 34 38 return array(); 35 39 }
+4
src/applications/diffusion/xaction/DiffusionCommitAcceptTransaction.php
··· 26 26 return 500; 27 27 } 28 28 29 + public function getActionName() { 30 + return pht('Accepted'); 31 + } 32 + 29 33 public function generateOldValue($object) { 30 34 $actor = $this->getActor(); 31 35 return $this->isViewerAcceptingAuditor($object, $actor);
+4
src/applications/diffusion/xaction/DiffusionCommitConcernTransaction.php
··· 26 26 return 600; 27 27 } 28 28 29 + public function getActionName() { 30 + return pht('Raised Concern'); 31 + } 32 + 29 33 public function generateOldValue($object) { 30 34 $actor = $this->getActor(); 31 35 return $this->isViewerRejectingAuditor($object, $actor);
+4
src/applications/diffusion/xaction/DiffusionCommitResignTransaction.php
··· 26 26 return 700; 27 27 } 28 28 29 + public function getActionName() { 30 + return pht('Resigned'); 31 + } 32 + 29 33 public function generateOldValue($object) { 30 34 $actor = $this->getActor(); 31 35 return !$this->isViewerAnyActiveAuditor($object, $actor);
+18
src/applications/transactions/storage/PhabricatorModularTransaction.php
··· 110 110 return parent::getTitle(); 111 111 } 112 112 113 + /* final */ public function getActionName() { 114 + $action = $this->getTransactionImplementation()->getActionName(); 115 + if ($action !== null) { 116 + return $action; 117 + } 118 + 119 + return parent::getActionName(); 120 + } 121 + 122 + /* final */ public function getActionStrength() { 123 + $strength = $this->getTransactionImplementation()->getActionStrength(); 124 + if ($strength !== null) { 125 + return $strength; 126 + } 127 + 128 + return parent::getActionStrength(); 129 + } 130 + 113 131 public function getTitleForMail() { 114 132 $old_target = $this->getRenderingTarget(); 115 133 $new_target = self::TARGET_TEXT;
+8
src/applications/transactions/storage/PhabricatorModularTransactionType.php
··· 59 59 return null; 60 60 } 61 61 62 + public function getActionName() { 63 + return null; 64 + } 65 + 66 + public function getActionStrength() { 67 + return null; 68 + } 69 + 62 70 public function getColor() { 63 71 return null; 64 72 }