recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Show the curent selected inline in the objective list

Summary: Ref T12733. When an inline is selected, make it stand out so you can see where you are in the document more clearly.

Test Plan: {F4968509}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12733

Differential Revision: https://secure.phabricator.com/D17982

epriestley 7d44e7cb e15009b7

+34 -13
+12 -12
resources/celerity/map.php
··· 13 13 'core.pkg.js' => '599698a7', 14 14 'darkconsole.pkg.js' => '1f9a31bc', 15 15 'differential.pkg.css' => '7d4cfa59', 16 - 'differential.pkg.js' => '886eadff', 16 + 'differential.pkg.js' => '1d120743', 17 17 'diffusion.pkg.css' => 'b93d9b8c', 18 18 'diffusion.pkg.js' => '84c8f8fd', 19 19 'favicon.ico' => '30672e08', ··· 391 391 'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375', 392 392 'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63', 393 393 'rsrc/js/application/diff/DiffChangeset.js' => 'cf4e2140', 394 - 'rsrc/js/application/diff/DiffChangesetList.js' => 'a716ca27', 395 - 'rsrc/js/application/diff/DiffInline.js' => '1478c3b2', 394 + 'rsrc/js/application/diff/DiffChangesetList.js' => '7a184082', 395 + 'rsrc/js/application/diff/DiffInline.js' => '19582231', 396 396 'rsrc/js/application/diff/ScrollObjective.js' => '7e8877e7', 397 397 'rsrc/js/application/diff/ScrollObjectiveList.js' => '6120e99a', 398 398 'rsrc/js/application/diff/behavior-preview-link.js' => '051c7832', ··· 778 778 'phabricator-darkmessage' => 'c48cccdd', 779 779 'phabricator-dashboard-css' => 'fe5b1869', 780 780 'phabricator-diff-changeset' => 'cf4e2140', 781 - 'phabricator-diff-changeset-list' => 'a716ca27', 782 - 'phabricator-diff-inline' => '1478c3b2', 781 + 'phabricator-diff-changeset-list' => '7a184082', 782 + 'phabricator-diff-inline' => '19582231', 783 783 'phabricator-drag-and-drop-file-upload' => '58dea2fa', 784 784 'phabricator-draggable-list' => 'bea6e7f4', 785 785 'phabricator-fatal-config-template-css' => '8f18fa41', ··· 981 981 'javelin-dom', 982 982 'javelin-typeahead-normalizer', 983 983 ), 984 - '1478c3b2' => array( 985 - 'javelin-dom', 986 - ), 987 984 '1499a8cb' => array( 988 985 'javelin-behavior', 989 986 'javelin-stratcom', ··· 1002 999 ), 1003 1000 '185bbd53' => array( 1004 1001 'javelin-install', 1002 + ), 1003 + 19582231 => array( 1004 + 'javelin-dom', 1005 1005 ), 1006 1006 '19f9369b' => array( 1007 1007 'phui-oi-list-view-css', ··· 1488 1488 'javelin-behavior', 1489 1489 'javelin-quicksand', 1490 1490 ), 1491 + '7a184082' => array( 1492 + 'javelin-install', 1493 + 'phabricator-scroll-objective-list', 1494 + ), 1491 1495 '7a68dda3' => array( 1492 1496 'owners-path-editor', 1493 1497 'javelin-behavior', ··· 1723 1727 'javelin-behavior', 1724 1728 'javelin-stratcom', 1725 1729 'javelin-dom', 1726 - ), 1727 - 'a716ca27' => array( 1728 - 'javelin-install', 1729 - 'phabricator-scroll-objective-list', 1730 1730 ), 1731 1731 'a80d0378' => array( 1732 1732 'javelin-behavior',
+15 -1
webroot/rsrc/js/application/diff/DiffChangesetList.js
··· 538 538 }, 539 539 540 540 _setSelectionState: function(item, manager) { 541 - this._cursorItem = item; 541 + // If we had an inline selected before, we need to update it after 542 + // changing our selection to clear the selected state. Then, update the 543 + // new one to add the selected state. 544 + var old_inline = this.getSelectedInline(); 542 545 546 + this._cursorItem = item; 543 547 this._redrawSelection(manager, true); 548 + 549 + var new_inline = this.getSelectedInline(); 550 + 551 + if (old_inline) { 552 + old_inline.updateObjective(); 553 + } 554 + 555 + if (new_inline) { 556 + new_inline.updateObjective(); 557 + } 544 558 545 559 return this; 546 560 },
+7
webroot/rsrc/js/application/diff/DiffInline.js
··· 250 250 should_stack = true; 251 251 } 252 252 253 + if (changeset.getChangesetList().getSelectedInline() === this) { 254 + // TODO: Maybe add some other kind of effect here, since we're only 255 + // using color to show this? 256 + color = 'yellow'; 257 + } 258 + 259 + 253 260 objective 254 261 .setAnchor(anchor) 255 262 .setIcon(icon)