@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a bug in the imageproxy controller
Summary: Somehow this got through last week :( It's a bug that causes the controller to... *ahem*... just not work. Luckily nothing uses this yet so nothing was really affected.
Test Plan: Hit `/file/imageproxy/?uri=http://i.imgur.com/nTvVrYN.jpg` and are served a nice picture of a bird
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: epriestley, yelirekim
Differential Revision: https://secure.phabricator.com/D16598
+1
-1
+1
-1
src/applications/files/controller/PhabricatorFileImageProxyController.php
+1
-1
src/applications/files/controller/PhabricatorFileImageProxyController.php
···
99
99
->setViewer(PhabricatorUser::getOmnipotentUser())
100
100
->withPHIDs(array($request->getFilePHID()))
101
101
->executeOne();
102
-
if (!file) {
102
+
if (!$file) {
103
103
throw new Exception(pht(
104
104
'The underlying file does not exist, but the cached request was '.
105
105
'successful. This likely means the file record was manually deleted '.