@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Merge branch 'master' into redesign-2015
+21
-19
+2
-2
src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
+2
-2
src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
···
127
127
}
128
128
129
129
$invited_phids = $saved->getParameter('invitedPHIDs');
130
-
$invited_phids = $user_datasource->evaluateTokens($invited_phids);
131
130
if ($invited_phids) {
131
+
$invited_phids = $user_datasource->evaluateTokens($invited_phids);
132
132
$query->withInvitedPHIDs($invited_phids);
133
133
}
134
134
135
135
$creator_phids = $saved->getParameter('creatorPHIDs');
136
-
$creator_phids = $user_datasource->evaluateTokens($creator_phids);
137
136
if ($creator_phids) {
137
+
$creator_phids = $user_datasource->evaluateTokens($creator_phids);
138
138
$query->withCreatorPHIDs($creator_phids);
139
139
}
140
140
-2
src/applications/celerity/resources/CelerityResources.php
-2
src/applications/celerity/resources/CelerityResources.php
-5
src/applications/phid/storage/PhabricatorPHID.php
-5
src/applications/phid/storage/PhabricatorPHID.php
···
2
2
3
3
final class PhabricatorPHID extends Phobject {
4
4
5
-
protected $phid;
6
-
protected $phidType;
7
-
protected $ownerPHID;
8
-
protected $parentPHID;
9
-
10
5
public static function generateNewPHID($type, $subtype = null) {
11
6
if (!$type) {
12
7
throw new Exception(pht('Can not generate PHID with no type.'));
+18
-9
src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php
+18
-9
src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php
···
5
5
6
6
const KEY_ALL = 'spaces.all';
7
7
const KEY_DEFAULT = 'spaces.default';
8
+
const KEY_VIEWER = 'spaces.viewer';
8
9
9
10
private $ids;
10
11
private $phids;
···
141
142
}
142
143
143
144
public static function getViewerSpaces(PhabricatorUser $viewer) {
144
-
$spaces = self::getAllSpaces();
145
+
$cache = PhabricatorCaches::getRequestCache();
146
+
$cache_key = self::KEY_VIEWER.'('.$viewer->getPHID().')';
145
147
146
-
$result = array();
147
-
foreach ($spaces as $key => $space) {
148
-
$can_see = PhabricatorPolicyFilter::hasCapability(
149
-
$viewer,
150
-
$space,
151
-
PhabricatorPolicyCapability::CAN_VIEW);
152
-
if ($can_see) {
153
-
$result[$key] = $space;
148
+
$result = $cache->getKey($cache_key);
149
+
if ($result === null) {
150
+
$spaces = self::getAllSpaces();
151
+
152
+
$result = array();
153
+
foreach ($spaces as $key => $space) {
154
+
$can_see = PhabricatorPolicyFilter::hasCapability(
155
+
$viewer,
156
+
$space,
157
+
PhabricatorPolicyCapability::CAN_VIEW);
158
+
if ($can_see) {
159
+
$result[$key] = $space;
160
+
}
154
161
}
162
+
163
+
$cache->setKey($cache_key, $result);
155
164
}
156
165
157
166
return $result;
+1
-1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+1
-1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php