@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Link Herald rules to rule detail pages in Herald transcripts
Summary: Fixes T9410. Depends on D16382. Since all users can now view all Herald rules, we can link them in the transcripts.
Test Plan: Viewed a transcript, clicked rule names, reviewed rules.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9410
Differential Revision: https://secure.phabricator.com/D16383
+6
-2
+6
-2
src/applications/herald/controller/HeraldTranscriptController.php
+6
-2
src/applications/herald/controller/HeraldTranscriptController.php
···
249
249
foreach ($rule_xscripts as $rule_xscript) {
250
250
$rule_id = $rule_xscript->getRuleID();
251
251
252
+
$rule_monogram = pht('H%d', $rule_id);
253
+
$rule_uri = '/'.$rule_monogram;
254
+
252
255
$rule_item = id(new PHUIObjectItemView())
253
-
->setObjectName(pht('H%d', $rule_id))
254
-
->setHeader($rule_xscript->getRuleName());
256
+
->setObjectName($rule_monogram)
257
+
->setHeader($rule_xscript->getRuleName())
258
+
->setHref($rule_uri);
255
259
256
260
if (!$rule_xscript->getResult()) {
257
261
$rule_item->setDisabled(true);