@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add ownerheads to workboard cards

Summary: Reworks cards to add an assignee head and tooltip on workboards. This feels like a reasonable starting point, but they may move depending on feedback.

Test Plan:
View a lot of boards. Assign and unassign a task.

{F1085739}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Luke081515.2, Korvin

Differential Revision: https://secure.phabricator.com/D15158

+37 -32
+10 -10
resources/celerity/map.php
··· 7 7 */ 8 8 return array( 9 9 'names' => array( 10 - 'core.pkg.css' => '0f87bfe0', 10 + 'core.pkg.css' => '8b9c004a', 11 11 'core.pkg.js' => 'bf947f93', 12 12 'darkconsole.pkg.js' => 'e7393ebb', 13 13 'differential.pkg.css' => '2de124c9', ··· 142 142 'rsrc/css/phui/phui-info-view.css' => '6d7c3509', 143 143 'rsrc/css/phui/phui-list.css' => '9da2aa00', 144 144 'rsrc/css/phui/phui-object-box.css' => '407eaf5a', 145 - 'rsrc/css/phui/phui-object-item-list-view.css' => '0d484a97', 145 + 'rsrc/css/phui/phui-object-item-list-view.css' => 'febf4a79', 146 146 'rsrc/css/phui/phui-pager.css' => 'bea33d23', 147 147 'rsrc/css/phui/phui-pinboard-view.css' => '2495140e', 148 148 'rsrc/css/phui/phui-profile-menu.css' => 'ab4fcf5f', ··· 154 154 'rsrc/css/phui/phui-timeline-view.css' => '2efceff8', 155 155 'rsrc/css/phui/phui-two-column-view.css' => 'c75bfc5b', 156 156 'rsrc/css/phui/workboards/phui-workboard.css' => 'b07a5524', 157 - 'rsrc/css/phui/workboards/phui-workcard.css' => '0dfd1880', 158 - 'rsrc/css/phui/workboards/phui-workpanel.css' => 'e9339dc3', 157 + 'rsrc/css/phui/workboards/phui-workcard.css' => 'ddb93318', 158 + 'rsrc/css/phui/workboards/phui-workpanel.css' => 'b90970eb', 159 159 'rsrc/css/sprite-login.css' => '60e8560e', 160 160 'rsrc/css/sprite-menu.css' => '9dd65b92', 161 161 'rsrc/css/sprite-tokens.css' => '4f399012', ··· 818 818 'phui-inline-comment-view-css' => '0fdb3667', 819 819 'phui-list-view-css' => '9da2aa00', 820 820 'phui-object-box-css' => '407eaf5a', 821 - 'phui-object-item-list-view-css' => '0d484a97', 821 + 'phui-object-item-list-view-css' => 'febf4a79', 822 822 'phui-pager-css' => 'bea33d23', 823 823 'phui-pinboard-view-css' => '2495140e', 824 824 'phui-profile-menu-css' => 'ab4fcf5f', ··· 831 831 'phui-timeline-view-css' => '2efceff8', 832 832 'phui-two-column-view-css' => 'c75bfc5b', 833 833 'phui-workboard-view-css' => 'b07a5524', 834 - 'phui-workcard-view-css' => '0dfd1880', 835 - 'phui-workpanel-view-css' => 'e9339dc3', 834 + 'phui-workcard-view-css' => 'ddb93318', 835 + 'phui-workpanel-view-css' => 'b90970eb', 836 836 'phuix-action-list-view' => 'b5c256b8', 837 837 'phuix-action-view' => '8cf6d262', 838 838 'phuix-autocomplete' => '9196fb06', ··· 1752 1752 'b6b0d1bb' => array( 1753 1753 'phui-inline-comment-view-css', 1754 1754 ), 1755 + 'b90970eb' => array( 1756 + 'phui-workcard-view-css', 1757 + ), 1755 1758 'ba4fa35c' => array( 1756 1759 'javelin-behavior', 1757 1760 'javelin-dom', ··· 1980 1983 ), 1981 1984 'e6e25838' => array( 1982 1985 'javelin-install', 1983 - ), 1984 - 'e9339dc3' => array( 1985 - 'phui-workcard-view-css', 1986 1986 ), 1987 1987 'e9581f08' => array( 1988 1988 'javelin-behavior',
+1 -1
src/applications/project/view/ProjectBoardTaskCard.php
··· 80 80 ->setBarColor($bar_color); 81 81 82 82 if ($owner) { 83 - $card->addAttribute($owner->renderLink()); 83 + $card->addHandleIcon($owner, $owner->getName()); 84 84 } 85 85 86 86 $project_phids = array_fuse($task->getProjectPHIDs());
+9 -5
src/view/phui/PHUIObjectItemView.php
··· 452 452 $icon_list); 453 453 } 454 454 455 + $handle_bar = null; 455 456 if ($this->handleIcons) { 456 457 $handle_bar = array(); 457 458 foreach ($this->handleIcons as $handleicon) { 458 459 $handle_bar[] = 459 460 $this->renderHandleIcon($handleicon['icon'], $handleicon['label']); 460 461 } 461 - $icons[] = phutil_tag( 462 - 'div', 462 + $handle_bar = phutil_tag( 463 + 'li', 463 464 array( 464 465 'class' => 'phui-object-item-handle-icons', 465 466 ), ··· 504 505 } 505 506 506 507 $attrs = null; 507 - if ($this->attributes) { 508 + if ($this->attributes || $handle_bar) { 508 509 $attrs = array(); 509 510 $spacer = phutil_tag( 510 511 'span', ··· 531 532 array( 532 533 'class' => 'phui-object-item-attributes', 533 534 ), 534 - $attrs); 535 + array( 536 + $handle_bar, 537 + $attrs, 538 + )); 535 539 } 536 540 537 541 $status = null; ··· 750 754 751 755 if (strlen($label)) { 752 756 $options['sigil'] = 'has-tooltip'; 753 - $options['meta'] = array('tip' => $label); 757 + $options['meta'] = array('tip' => $label, 'align' => 'E'); 754 758 } 755 759 756 760 return javelin_tag('span', $options, '');
+8 -13
webroot/rsrc/css/phui/phui-object-item-list-view.css
··· 297 297 .phui-object-item-attributes { 298 298 padding: 0 8px 6px; 299 299 line-height: 18px; 300 + min-height: 21px; 300 301 } 301 302 302 303 .phui-object-item-attribute { 303 - display: inline; 304 + display: inline-block; 304 305 color: {$greytext}; 306 + vertical-align: middle; 305 307 } 306 308 307 309 .phui-object-item-attribute-spacer { ··· 322 324 323 325 .device-phone .phui-object-icon-pane { 324 326 margin: 0 0 4px; 325 - } 326 - 327 - .phui-object-item-with-handle-icons .phui-object-item-icons { 328 - padding-bottom: 30px; 329 327 } 330 328 331 329 .phui-object-item-icons { ··· 537 535 */ 538 536 539 537 .phui-object-item-handle-icons { 540 - height: 28px; 541 - margin-right: 10px; 542 538 bottom: 0; 543 - right: 0; 544 - text-align: right; 539 + right: 4px; 545 540 position: absolute; 546 541 } 547 542 548 543 .phui-object-item-handle-icon { 549 - margin: 1px; 550 - width: 28px; 551 - height: 28px; 544 + width: 24px; 545 + height: 24px; 552 546 display: inline-block; 553 - background-size: 28px 28px; 547 + background-size: 100%; 548 + border-radius: 3px; 554 549 background-repeat: no-repeat; 555 550 } 556 551
+8 -2
webroot/rsrc/css/phui/workboards/phui-workcard.css
··· 5 5 .phui-workpanel-view .phui-object-item { 6 6 background-color: #fff; 7 7 border-radius: 3px; 8 - margin-bottom: 6px; 8 + margin-bottom: 8px; 9 9 } 10 10 11 11 .phui-workpanel-view .phui-object-item-name { ··· 19 19 .phui-workpanel-view .phui-object-item-frame { 20 20 border-top-right-radius: 3px; 21 21 border-bottom-right-radius: 3px; 22 + border-color: {$thinblueborder}; 23 + border-bottom-color: {$lightblueborder}; 22 24 } 23 25 24 26 .phui-workpanel-view .phui-object-item .phui-object-item-objname { ··· 60 62 } 61 63 62 64 .phui-workpanel-view .phui-object-item .phui-list-item-href { 63 - height: 26px; 65 + height: 24px; 66 + width: 24px; 64 67 } 65 68 66 69 .device-desktop .phui-workpanel-view .phui-object-item:hover ··· 79 82 display: block; 80 83 } 81 84 85 + .phui-workpanel-view .phui-object-item-attributes { 86 + margin-right: 12px; 87 + } 82 88 83 89 84 90
+1 -1
webroot/rsrc/css/phui/workboards/phui-workpanel.css
··· 44 44 padding: 8px 8px 4px 8px; 45 45 } 46 46 47 - .device-phone .phui-workpanel-view .phui-workpanel-body { 47 + .device .phui-workpanel-view .phui-workpanel-body { 48 48 padding: 8px 0; 49 49 } 50 50