@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Toggle accept warnings on reload
Summary: We now remember this value, it's remembered also after page refresh.
Test Plan: Reloaded revision about to be accepted.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D4196
+13
-15
+13
-15
webroot/rsrc/js/application/differential/behavior-accept-with-errors.js
+13
-15
webroot/rsrc/js/application/differential/behavior-accept-with-errors.js
···
5
5
*/
6
6
7
7
JX.behavior('differential-accept-with-errors', function(config) {
8
+
if (config.warnings) {
9
+
toggleWarning();
10
+
JX.DOM.listen(
11
+
JX.$(config.select),
12
+
'change',
13
+
null,
14
+
toggleWarning);
15
+
}
8
16
9
-
function toggleWarning(control) {
10
-
if (control) {
11
-
JX.DOM.hide(JX.$(control));
12
-
JX.DOM.listen(
13
-
JX.$(config.select),
14
-
'change',
15
-
null,
16
-
function(e) {
17
-
if (JX.$(config.select).value == 'accept') {
18
-
JX.DOM.show(JX.$(control));
19
-
} else {
20
-
JX.DOM.hide(JX.$(control));
21
-
}
22
-
});
17
+
function toggleWarning() {
18
+
if (JX.$(config.select).value == 'accept') {
19
+
JX.DOM.show(JX.$(config.warnings));
20
+
} else {
21
+
JX.DOM.hide(JX.$(config.warnings));
23
22
}
24
23
}
25
24
26
-
toggleWarning(config.warnings);
27
25
});