@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Give all commands from DiffusionCommandEngine a default 15 minute timeout
Summary:
Ref T13108. See PHI364. See the task and issue for discussion.
If a `git fetch` during synchronization hangs, the whole node currently hangs. While the causes of a `git fetch` hang aren't clear, we don't expect synchronization to ever reasonably take more than 15 minutes, so add a default timeout.
Test Plan: Will deploy and observe; this is difficult to reproduce or test directly.
Maniphest Tasks: T13108
Differential Revision: https://secure.phabricator.com/D19235
+5
+5
src/applications/diffusion/protocol/DiffusionCommandEngine.php
+5
src/applications/diffusion/protocol/DiffusionCommandEngine.php
···
135
135
136
136
$future->setEnv($env);
137
137
138
+
// See T13108. By default, don't let any cluster command run indefinitely
139
+
// to try to avoid cases where `git fetch` hangs for some reason and we're
140
+
// left sitting with a held lock forever.
141
+
$future->setTimeout(phutil_units('15 minutes in seconds'));
142
+
138
143
return $future;
139
144
}
140
145