@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Improve puncutation usage
Summary: Use periods where appropriate.
Test Plan: shipitquick
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D11110
+51
-65
+3
-3
src/applications/maniphest/storage/ManiphestTransaction.php
+3
-3
src/applications/maniphest/storage/ManiphestTransaction.php
···
503
503
$removed = array_diff($old, $new);
504
504
if ($added && !$removed) {
505
505
return pht(
506
-
'%s attached %d file(s): %s',
506
+
'%s attached %d file(s): %s.',
507
507
$this->renderHandleLink($author_phid),
508
508
count($added),
509
509
$this->renderHandleList($added));
510
510
} else if ($removed && !$added) {
511
511
return pht(
512
-
'%s detached %d file(s): %s',
512
+
'%s detached %d file(s): %s.',
513
513
$this->renderHandleLink($author_phid),
514
514
count($removed),
515
515
$this->renderHandleList($removed));
516
516
} else {
517
517
return pht(
518
-
'%s changed file(s), attached %d: %s; detached %d: %s',
518
+
'%s changed file(s), attached %d: %s; detached %d: %s.',
519
519
$this->renderHandleLink($author_phid),
520
520
count($added),
521
521
$this->renderHandleList($added),
+1
-1
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+1
-1
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+6
-6
src/applications/project/storage/PhabricatorProjectTransaction.php
+6
-6
src/applications/project/storage/PhabricatorProjectTransaction.php
···
118
118
119
119
if ($add && $rem) {
120
120
return pht(
121
-
'%s changed project hashtag(s), added %d: %s; removed %d: %s',
121
+
'%s changed project hashtag(s), added %d: %s; removed %d: %s.',
122
122
$author_handle,
123
123
count($add),
124
124
$this->renderSlugList($add),
···
126
126
$this->renderSlugList($rem));
127
127
} else if ($add) {
128
128
return pht(
129
-
'%s added %d project hashtag(s): %s',
129
+
'%s added %d project hashtag(s): %s.',
130
130
$author_handle,
131
131
count($add),
132
132
$this->renderSlugList($add));
133
133
} else if ($rem) {
134
134
return pht(
135
-
'%s removed %d project hashtag(s): %s',
135
+
'%s removed %d project hashtag(s): %s.',
136
136
$author_handle,
137
137
count($rem),
138
138
$this->renderSlugList($rem));
···
144
144
145
145
if ($add && $rem) {
146
146
return pht(
147
-
'%s changed project member(s), added %d: %s; removed %d: %s',
147
+
'%s changed project member(s), added %d: %s; removed %d: %s.',
148
148
$author_handle,
149
149
count($add),
150
150
$this->renderHandleList($add),
···
157
157
$author_handle);
158
158
} else {
159
159
return pht(
160
-
'%s added %d project member(s): %s',
160
+
'%s added %d project member(s): %s.',
161
161
$author_handle,
162
162
count($add),
163
163
$this->renderHandleList($add));
···
169
169
$author_handle);
170
170
} else {
171
171
return pht(
172
-
'%s removed %d project member(s): %s',
172
+
'%s removed %d project member(s): %s.',
173
173
$author_handle,
174
174
count($rem),
175
175
$this->renderHandleList($rem));
+41
-55
src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php
+41
-55
src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php
···
131
131
),
132
132
133
133
'%s edited member(s), added %d: %s; removed %d: %s.' =>
134
-
'%s edited members, added: %3$s; removed: %5$s',
134
+
'%s edited members, added: %3$s; removed: %5$s.',
135
135
136
136
'%s added %d member(s): %s.' => array(
137
137
array(
···
148
148
),
149
149
150
150
'%s edited project(s), added %d: %s; removed %d: %s.' =>
151
-
'%s edited projects, added: %3$s; removed: %5$s',
151
+
'%s edited projects, added: %3$s; removed: %5$s.',
152
152
153
153
'%s added %d project(s): %s.' => array(
154
154
array(
···
249
249
),
250
250
251
251
'%s edited blocking task(s), added %s: %s; removed %s: %s.' =>
252
-
'%s edited blocking tasks, added: %3$s; removed: %5$s',
252
+
'%s edited blocking tasks, added: %3$s; removed: %5$s.',
253
253
254
254
'%s edited blocking task(s) for %s, added %s: %s; removed %s: %s.' =>
255
-
'%s edited blocking tasks for %s, added: %4$s; removed: %6$s',
255
+
'%s edited blocking tasks for %s, added: %4$s; removed: %6$s.',
256
256
257
257
'%s edited blocked task(s), added %s: %s; removed %s: %s.' =>
258
-
'%s edited blocked tasks, added: %3$s; removed: %5$s',
258
+
'%s edited blocked tasks, added: %3$s; removed: %5$s.',
259
259
260
260
'%s edited blocked task(s) for %s, added %s: %s; removed %s: %s.' =>
261
-
'%s edited blocked tasks for %s, added: %4$s; removed: %6$s',
261
+
'%s edited blocked tasks for %s, added: %4$s; removed: %6$s.',
262
262
263
263
'%s edited answer(s), added %s: %s; removed %d: %s.' =>
264
-
'%s edited answers, added: %3$s; removed: %5$s',
264
+
'%s edited answers, added: %3$s; removed: %5$s.',
265
265
266
266
'%s added %s answer(s): %s.' => array(
267
267
array(
···
278
278
),
279
279
280
280
'%s edited question(s), added %s: %s; removed %s: %s.' =>
281
-
'%s edited questions, added: %3$s; removed: %5$s',
281
+
'%s edited questions, added: %3$s; removed: %5$s.',
282
282
283
283
'%s added %s question(s): %s.' => array(
284
284
array(
···
295
295
),
296
296
297
297
'%s edited mock(s), added %d: %s; removed %d: %s.' =>
298
-
'%s edited mocks, added: %3$s; removed: %5$s',
298
+
'%s edited mocks, added: %3$s; removed: %5$s.',
299
299
300
300
'%s added %d mock(s): %s.' => array(
301
301
array(
···
326
326
),
327
327
328
328
'%s edited file(s), added %d: %s; removed %d: %s.' =>
329
-
'%s edited files, added: %3$s; removed: %5$s',
329
+
'%s edited files, added: %3$s; removed: %5$s.',
330
330
331
331
'%s added %d file(s): %s.' => array(
332
332
array(
···
343
343
),
344
344
345
345
'%s edited contributor(s), added %d: %s; removed %d: %s.' =>
346
-
'%s edited contributors, added: %3$s; removed: %5$s',
346
+
'%s edited contributors, added: %3$s; removed: %5$s.',
347
347
348
348
'%s added %d contributor(s): %s.' => array(
349
349
array(
···
360
360
),
361
361
362
362
'%s edited reviewer(s), added %s: %s; removed %s: %s.' =>
363
-
'%s edited reviewers, added: %4$s; removed: %6$s',
363
+
'%s edited reviewers, added: %4$s; removed: %6$s.',
364
364
365
365
'%s added %s reviewer(s): %s.' => array(
366
366
array(
···
377
377
),
378
378
379
379
'%s edited object(s), added %d: %s; removed %d: %s.' =>
380
-
'%s edited objects, added: %3$s; removed: %5$s',
380
+
'%s edited objects, added: %3$s; removed: %5$s.',
381
381
382
382
'%s added %d object(s): %s.' => array(
383
383
array(
···
399
399
),
400
400
401
401
'%s edited subscriber(s), added %d: %s; removed %d: %s.' =>
402
-
'%s edited subscribers, added: %3$s; removed: %5$s',
402
+
'%s edited subscribers, added: %3$s; removed: %5$s.',
403
403
404
404
'%s added %d subscriber(s): %s.' => array(
405
405
array(
···
416
416
),
417
417
418
418
'%s edited participant(s), added %d: %s; removed %d: %s.' =>
419
-
'%s edited participants, added: %3$s; removed: %5$s',
419
+
'%s edited participants, added: %3$s; removed: %5$s.',
420
420
421
421
'%s added %d participant(s): %s.' => array(
422
422
array(
···
551
551
'%s Commits',
552
552
),
553
553
554
-
'%s added %d project(s): %s' => array(
555
-
array(
556
-
'%s added a project: %3$s',
557
-
'%s added projects: %3$s',
558
-
),
559
-
),
560
-
561
-
'%s removed %d project(s): %s' => array(
562
-
array(
563
-
'%s removed a project: %3$s',
564
-
'%s removed projects: %3$s',
565
-
),
566
-
),
567
-
568
-
'%s attached %d file(s): %s' => array(
554
+
'%s attached %d file(s): %s.' => array(
569
555
array(
570
-
'%s attached a file: %3$s',
571
-
'%s attached files: %3$s',
556
+
'%s attached a file: %3$s.',
557
+
'%s attached files: %3$s.',
572
558
),
573
559
),
574
560
575
-
'%s detached %d file(s): %s' => array(
561
+
'%s detached %d file(s): %s.' => array(
576
562
array(
577
-
'%s detached a file: %3$s',
578
-
'%s detached files: %3$s',
563
+
'%s detached a file: %3$s.',
564
+
'%s detached files: %3$s.',
579
565
),
580
566
),
581
567
582
-
'%s changed file(s), attached %d: %s; detached %d: %s' =>
583
-
'%s changed files, attached: %3$s; detached: %5$s',
568
+
'%s changed file(s), attached %d: %s; detached %d: %s.' =>
569
+
'%s changed files, attached: %3$s; detached: %5$s.',
584
570
585
571
586
572
'%s added %s dependencie(s): %s.' => array(
···
628
614
'%s edited commit(s), added %s: %s; removed %s: %s.' =>
629
615
'%s edited commits, added %3$s; removed %5$s.',
630
616
631
-
'%s changed project member(s), added %d: %s; removed %d: %s' =>
632
-
'%s changed project members, added %3$s; removed %5$s',
617
+
'%s changed project member(s), added %d: %s; removed %d: %s.' =>
618
+
'%s changed project members, added %3$s; removed %5$s.',
633
619
634
-
'%s added %d project member(s): %s' => array(
620
+
'%s added %d project member(s): %s.' => array(
635
621
array(
636
-
'%s added a member: %3$s',
637
-
'%s added members: %3$s',
622
+
'%s added a member: %3$s.',
623
+
'%s added members: %3$s.',
638
624
),
639
625
),
640
626
641
-
'%s removed %d project member(s): %s' => array(
627
+
'%s removed %d project member(s): %s.' => array(
642
628
array(
643
-
'%s removed a member: %3$s',
644
-
'%s removed members: %3$s',
629
+
'%s removed a member: %3$s.',
630
+
'%s removed members: %3$s.',
645
631
),
646
632
),
647
633
648
-
'%d project hashtag(s) are already used: %s' => array(
634
+
'%d project hashtag(s) are already used: %s.' => array(
649
635
'Project hashtag %2$s is already used.',
650
-
'%d project hashtags are already used: %2$s',
636
+
'%d project hashtags are already used: %2$s.',
651
637
),
652
638
653
-
'%s changed project hashtag(s), added %d: %s; removed %d: %s' =>
654
-
'%s changed project hashtags, added %3$s; removed %5$s',
639
+
'%s changed project hashtag(s), added %d: %s; removed %d: %s.' =>
640
+
'%s changed project hashtags, added %3$s; removed %5$s.',
655
641
656
-
'%s added %d project hashtag(s): %s' => array(
642
+
'%s added %d project hashtag(s): %s.' => array(
657
643
array(
658
-
'%s added a hashtag: %3$s',
659
-
'%s added hashtags: %3$s',
644
+
'%s added a hashtag: %3$s.',
645
+
'%s added hashtags: %3$s.',
660
646
),
661
647
),
662
648
663
-
'%s removed %d project hashtag(s): %s' => array(
649
+
'%s removed %d project hashtag(s): %s.' => array(
664
650
array(
665
-
'%s removed a hashtag: %3$s',
666
-
'%s removed hashtags: %3$s',
651
+
'%s removed a hashtag: %3$s.',
652
+
'%s removed hashtags: %3$s.',
667
653
),
668
654
),
669
655