@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clarify "Closed" revision status with VCS-specific language
Summary: Instead of rendering "Revision Status: Closed (Sat, Apr 28, 10:28 AM)", render "Revision Status: Closed (Pushed Sat, Apr 28, 10:28 AM)", or "Committed", as appropriate.
Test Plan: Looked at a committed revision.
Reviewers: btrahan, vrana, jungejason
Reviewed By: jungejason
CC: jeffmo, rdbayer, aran
Maniphest Tasks: T909
Differential Revision: https://secure.phabricator.com/D2334
+14
-2
+14
-2
src/applications/differential/field/specification/revisionstatus/DifferentialRevisionStatusFieldSpecification.php
+14
-2
src/applications/differential/field/specification/revisionstatus/DifferentialRevisionStatusFieldSpecification.php
···
33
33
34
34
$status = $revision->getStatus();
35
35
$info = null;
36
+
$vcs = $diff->getSourceControlSystem();
36
37
37
38
if ($status == ArcanistDifferentialRevisionStatus::ACCEPTED) {
38
-
switch ($diff->getSourceControlSystem()) {
39
+
switch ($vcs) {
39
40
case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
40
41
$next_step = '<tt>hg push</tt>';
41
42
break;
···
52
53
53
54
} else if ($status == ArcanistDifferentialRevisionStatus::CLOSED) {
54
55
$committed = $revision->getDateCommitted();
55
-
$info = ' ('.phabricator_datetime($committed, $this->getUser()).')';
56
+
switch ($vcs) {
57
+
case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
58
+
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
59
+
$verb = 'Pushed';
60
+
break;
61
+
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
62
+
$verb = 'Committed';
63
+
break;
64
+
}
65
+
$when = phabricator_datetime($committed, $this->getUser());
66
+
67
+
$info = " ({$verb} {$when})";
56
68
}
57
69
58
70
$status =