@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make closed/disabled results in the remarkup autocomplete more visually clear

Summary:
Ref T13114. See PHI522. Although it looks like results are already ordered correctly, the override rendering isn't accommodating disabled results gracefully.

Give closed results a distinctive look (grey + strikethru) so it's clear when you're autocompleting `@mention...` into a disabled user.

Test Plan: {F5497621}

Maniphest Tasks: T13114

Differential Revision: https://secure.phabricator.com/D19272

+20 -12
+11 -11
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => 'e68cf1fa', 11 11 'conpherence.pkg.js' => '15191c65', 12 - 'core.pkg.css' => '3fd3b7b8', 12 + 'core.pkg.css' => '1dd5fa4b', 13 13 'core.pkg.js' => 'b9b4a943', 14 14 'differential.pkg.css' => '113e692c', 15 15 'differential.pkg.js' => 'f6d809c0', ··· 112 112 'rsrc/css/application/tokens/tokens.css' => '3d0f239e', 113 113 'rsrc/css/application/uiexample/example.css' => '528b19de', 114 114 'rsrc/css/core/core.css' => '62fa3ace', 115 - 'rsrc/css/core/remarkup.css' => 'b375546d', 115 + 'rsrc/css/core/remarkup.css' => '1828e2ad', 116 116 'rsrc/css/core/syntax.css' => 'cae95e89', 117 117 'rsrc/css/core/z-index.css' => '9d8f7c4b', 118 118 'rsrc/css/diviner/diviner-shared.css' => '896f1d43', ··· 509 509 'rsrc/js/phui/behavior-phui-tab-group.js' => '0a0b10e9', 510 510 'rsrc/js/phuix/PHUIXActionListView.js' => 'b5c256b8', 511 511 'rsrc/js/phuix/PHUIXActionView.js' => 'ed18356a', 512 - 'rsrc/js/phuix/PHUIXAutocomplete.js' => '7fa5c915', 512 + 'rsrc/js/phuix/PHUIXAutocomplete.js' => 'df1bbd34', 513 513 'rsrc/js/phuix/PHUIXButtonView.js' => '8a91e1ac', 514 514 'rsrc/js/phuix/PHUIXDropdownMenu.js' => '04b2ae03', 515 515 'rsrc/js/phuix/PHUIXExample.js' => '68af71ca', ··· 780 780 'phabricator-object-selector-css' => '85ee8ce6', 781 781 'phabricator-phtize' => 'd254d646', 782 782 'phabricator-prefab' => '77b0ae28', 783 - 'phabricator-remarkup-css' => 'b375546d', 783 + 'phabricator-remarkup-css' => '1828e2ad', 784 784 'phabricator-search-results-css' => '505dd8cf', 785 785 'phabricator-shaped-request' => '7cbe244b', 786 786 'phabricator-slowvote-css' => 'a94b7230', ··· 865 865 'phui-workpanel-view-css' => 'a3a63478', 866 866 'phuix-action-list-view' => 'b5c256b8', 867 867 'phuix-action-view' => 'ed18356a', 868 - 'phuix-autocomplete' => '7fa5c915', 868 + 'phuix-autocomplete' => 'df1bbd34', 869 869 'phuix-button-view' => '8a91e1ac', 870 870 'phuix-dropdown-menu' => '04b2ae03', 871 871 'phuix-form-control-view' => '210a16c1', ··· 1558 1558 '7f243deb' => array( 1559 1559 'javelin-install', 1560 1560 ), 1561 - '7fa5c915' => array( 1562 - 'javelin-install', 1563 - 'javelin-dom', 1564 - 'phuix-icon-view', 1565 - 'phabricator-prefab', 1566 - ), 1567 1561 '834a1173' => array( 1568 1562 'javelin-behavior', 1569 1563 'javelin-scrollbar', ··· 2046 2040 'javelin-typeahead', 2047 2041 'javelin-typeahead-ondemand-source', 2048 2042 'javelin-dom', 2043 + ), 2044 + 'df1bbd34' => array( 2045 + 'javelin-install', 2046 + 'javelin-dom', 2047 + 'phuix-icon-view', 2048 + 'phabricator-prefab', 2049 2049 ), 2050 2050 'e1d25dfb' => array( 2051 2051 'javelin-behavior',
+5
webroot/rsrc/css/core/remarkup.css
··· 724 724 color: {$darkgreytext}; 725 725 } 726 726 727 + .phuix-autocomplete-list a.jx-result .tokenizer-result-closed { 728 + color: {$lightgreytext}; 729 + text-decoration: line-through; 730 + } 731 + 727 732 .phuix-autocomplete-list a.jx-result .phui-icon-view { 728 733 margin-right: 4px; 729 734 color: {$lightbluetext};
+4 -1
webroot/rsrc/js/phuix/PHUIXAutocomplete.js
··· 185 185 .getNode(); 186 186 } 187 187 188 - map.display = [icon, map.displayName]; 188 + var display = JX.$N('span', {}, [icon, map.displayName]); 189 + JX.DOM.alterClass(display, 'tokenizer-result-closed', !!map.closed); 190 + 191 + map.display = display; 189 192 190 193 return map; 191 194 },