@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix 404 clicking Find Owners in diffusion, if Owners application is disabled.
Test Plan: Install/uninstall Owners application, Find Owners action shown/hidden as expected.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley
CC: Korvin, epriestley, aran
Differential Revision: https://secure.phabricator.com/D7557
authored by
Brecht Van Lommel
and committed by
epriestley
7ec42dbb
71adee75
+14
-11
+14
-11
src/applications/diffusion/controller/DiffusionBrowseController.php
+14
-11
src/applications/diffusion/controller/DiffusionBrowseController.php
···
104
104
// TODO: Ideally, this should live in Owners and be event-triggered, but
105
105
// there's no reasonable object for it to react to right now.
106
106
107
-
$owners_uri = id(new PhutilURI('/owners/view/search/'))
108
-
->setQueryParams(
109
-
array(
110
-
'repository' => $drequest->getCallsign(),
111
-
'path' => '/'.$drequest->getPath(),
112
-
));
107
+
$owners = 'PhabricatorApplicationOwners';
108
+
if (PhabricatorApplication::isClassInstalled($owners)) {
109
+
$owners_uri = id(new PhutilURI('/owners/view/search/'))
110
+
->setQueryParams(
111
+
array(
112
+
'repository' => $drequest->getCallsign(),
113
+
'path' => '/'.$drequest->getPath(),
114
+
));
113
115
114
-
$view->addAction(
115
-
id(new PhabricatorActionView())
116
-
->setName(pht('Find Owners'))
117
-
->setHref((string)$owners_uri)
118
-
->setIcon('preview'));
116
+
$view->addAction(
117
+
id(new PhabricatorActionView())
118
+
->setName(pht('Find Owners'))
119
+
->setHref((string)$owners_uri)
120
+
->setIcon('preview'));
121
+
}
119
122
120
123
return $view;
121
124
}