recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Diviner: Remove line about MySQL issues with indexes for tuple search

Summary:
Older MySQL versions had performance issues in query optimization for tuple comparisons in an IN clause.
These issues were mostly fixed for MySQL 5.6; see https://bugs.mysql.com/bug.php?id=31188

While there are still some issues (e.g. https://bugs.mysql.com/bug.php?id=115190), nowadays tuple search index usage is generally supported.

Phorge requires MySQL 8 since rP555fb3a8 / T16107. So this sentence is now moot.

Test Plan:
* Search the interwebs
* Run `./bin/diviner generate`, read http://phorge.localhost/book/contrib/article/database/

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26472

Andre Klapper 7ee80e43 ec0ef684

-4
-4
src/docs/contributor/database.diviner
··· 115 115 create indexes which are not used. You can analyze queries @{article:Using 116 116 DarkConsole}. 117 117 118 - Older MySQL versions are not able to use indexes for tuple search: 119 - `(a, b) IN ((%s, %d), (%s, %d))`. Use `AND` and `OR` instead: 120 - `((a = %s AND b = %d) OR (a = %s AND b = %d))`. 121 - 122 118 Foreign Keys 123 119 ============ 124 120