@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Conpherence + workboards - fix dragging behavior breaking on subsequent page loads
Summary: Fixes T8155. The former "init_board()" function was aptly named as it needs to be called each time a new board dom piece is downloaded. Ergo, break out a setup() function and call that in the once-only setup place, and use init_board() there as well as when we have a quicksand redraw event with data from the server.
Test Plan: paged about a project and was able to keep dragging and dropping tasks on various loads of the board. verified drops saved correctly from load to load.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8155
Differential Revision: https://secure.phabricator.com/D12798
+19
-12
+11
-11
resources/celerity/map.php
+11
-11
resources/celerity/map.php
···
407
407
'rsrc/js/application/policy/behavior-policy-control.js' => '9a340b3d',
408
408
'rsrc/js/application/policy/behavior-policy-rule-editor.js' => '5e9f347c',
409
409
'rsrc/js/application/ponder/behavior-votebox.js' => '4e9b766b',
410
-
'rsrc/js/application/projects/behavior-project-boards.js' => '60292820',
410
+
'rsrc/js/application/projects/behavior-project-boards.js' => 'ba4fa35c',
411
411
'rsrc/js/application/projects/behavior-project-create.js' => '065227cc',
412
412
'rsrc/js/application/projects/behavior-reorder-columns.js' => 'e1d25dfb',
413
413
'rsrc/js/application/releeph/releeph-preview-branch.js' => 'b2b4fbaf',
···
637
637
'javelin-behavior-policy-control' => '9a340b3d',
638
638
'javelin-behavior-policy-rule-editor' => '5e9f347c',
639
639
'javelin-behavior-ponder-votebox' => '4e9b766b',
640
-
'javelin-behavior-project-boards' => '60292820',
640
+
'javelin-behavior-project-boards' => 'ba4fa35c',
641
641
'javelin-behavior-project-create' => '065227cc',
642
642
'javelin-behavior-quicksand-blacklist' => '7927a7d3',
643
643
'javelin-behavior-refresh-csrf' => '7814b593',
···
1247
1247
'javelin-workflow',
1248
1248
'javelin-stratcom',
1249
1249
),
1250
-
60292820 => array(
1251
-
'javelin-behavior',
1252
-
'javelin-dom',
1253
-
'javelin-util',
1254
-
'javelin-vector',
1255
-
'javelin-stratcom',
1256
-
'javelin-workflow',
1257
-
'phabricator-draggable-list',
1258
-
),
1259
1250
60479091 => array(
1260
1251
'phabricator-busy',
1261
1252
'javelin-behavior',
···
1728
1719
'javelin-stratcom',
1729
1720
'javelin-dom',
1730
1721
'javelin-util',
1722
+
),
1723
+
'ba4fa35c' => array(
1724
+
'javelin-behavior',
1725
+
'javelin-dom',
1726
+
'javelin-util',
1727
+
'javelin-vector',
1728
+
'javelin-stratcom',
1729
+
'javelin-workflow',
1730
+
'phabricator-draggable-list',
1731
1731
),
1732
1732
'bba9eedf' => array(
1733
1733
'javelin-behavior',
+8
-1
webroot/rsrc/js/application/projects/behavior-project-boards.js
+8
-1
webroot/rsrc/js/application/projects/behavior-project-boards.js
···
249
249
for (ii = 0; ii < lists.length; ii++) {
250
250
lists[ii].setGroup(lists);
251
251
}
252
+
}
253
+
254
+
function setup() {
252
255
253
256
JX.Stratcom.listen(
254
257
'click',
···
336
339
statics.boardID = new_config.boardID;
337
340
}
338
341
update_statics(new_config);
342
+
if (data.fromServer) {
343
+
init_board();
344
+
}
339
345
});
340
346
return true;
341
347
}
···
345
351
var current_page_id = JX.Quicksand.getCurrentPageID();
346
352
statics.boardConfigCache = {};
347
353
statics.boardConfigCache[current_page_id] = config;
348
-
statics.setup = init_board();
354
+
init_board();
355
+
statics.setup = setup();
349
356
}
350
357
351
358
});