@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument
Summary: This commit harmonizes PhabricatorNotificationServerRef's getURI and getWebsocketURI methods as discussed in D25382.
Test Plan: This is hard to say since I didn't know how/when this function might be called.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25401
+2
-2
+2
-2
src/applications/notification/client/PhabricatorNotificationServerRef.php
+2
-2
src/applications/notification/client/PhabricatorNotificationServerRef.php
···
161
161
return $uri;
162
162
}
163
163
164
-
public function getWebsocketURI($to_path = null) {
164
+
public function getWebsocketURI($to_path = '') {
165
165
$instance = PhabricatorEnv::getEnvConfig('cluster.instance');
166
-
if (strlen($instance)) {
166
+
if (phutil_nonempty_string($instance)) {
167
167
$to_path = $to_path.'~'.$instance.'/';
168
168
}
169
169