@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add required needMembers/needWatchers calls to Project Profile/Subprojects tabs
Summary:
Fixes T12710. See that task for discussion. This is pretty ugly/redundant but not broken.
(Feel free to reject this and pursue something else.)
Test Plan:
- For a project with active subprojects/milestones, viewed the project profile and subprojects tabs.
- After patch: they're ugly, but no longer fatal.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12710
Differential Revision: https://secure.phabricator.com/D17882
+6
+2
src/applications/project/controller/PhabricatorProjectProfileController.php
+2
src/applications/project/controller/PhabricatorProjectProfileController.php
+4
src/applications/project/controller/PhabricatorProjectSubprojectsController.php
+4
src/applications/project/controller/PhabricatorProjectSubprojectsController.php
···
31
31
->setViewer($viewer)
32
32
->withParentProjectPHIDs(array($project->getPHID()))
33
33
->needImages(true)
34
+
->needMembers(true)
35
+
->needWatchers(true)
34
36
->withIsMilestone(false)
35
37
->execute();
36
38
} else {
···
42
44
->setViewer($viewer)
43
45
->withParentProjectPHIDs(array($project->getPHID()))
44
46
->needImages(true)
47
+
->needMembers(true)
48
+
->needWatchers(true)
45
49
->withIsMilestone(true)
46
50
->setOrderVector(array('milestoneNumber', 'id'))
47
51
->execute();