recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add missing execution on archived task query

Summary: Fixes T8599. I'm not sure how to reproduce the original issue, but I'm fairly confident that the issue is that the issue is that `execute()` is not called on the query object.

Test Plan: Created a Harbormaster build plan with a single "Lease Host" step. Ran `./bin/harbormaster build --plan 1 D1` from the command line and hit the exception as described in T8599. Applied patch and hit a different exception (which I think is just because I don't know how to use #drydock and #harbormaster).

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: hach-que, epriestley, Korvin

Maniphest Tasks: T8599

Differential Revision: https://secure.phabricator.com/D13335

Joshua Spence 7f6508af dad29171

+2 -1
+2 -1
src/infrastructure/daemon/workers/PhabricatorWorker.php
··· 199 199 } 200 200 201 201 $tasks = id(new PhabricatorWorkerArchiveTaskQuery()) 202 - ->withIDs($task_ids); 202 + ->withIDs($task_ids) 203 + ->execute(); 203 204 204 205 foreach ($tasks as $task) { 205 206 if ($task->getResult() != PhabricatorWorkerArchiveTask::RESULT_SUCCESS) {