@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make the "Requested Changes to Prior Diff" reviewer icon red, not bluegrey

Summary: See PHI31. The "Accepted Older Revision" icon is (more reasonably) bluegrey, but that rule spilled over here where it doesn't make much sense. "Requested Changes to Prior Diff" remains in effect across updates, but the coloration implies otherwise.

Test Plan:
"Requested Changes to This Diff" (unchanged):

{F5092019}

"Requested Changes to Prior Diff" (now red, previously bluegrey):

{F5092020}

Note that the icons are different so this is technically colorblind-safe, and it's normally not important to distinguish between these two reds anyway.

Reviewers: chad, lvital

Reviewed By: lvital

Subscribers: lvital

Differential Revision: https://secure.phabricator.com/D18385

+1 -1
+1 -1
src/applications/differential/view/DifferentialReviewersView.php
··· 116 116 } 117 117 } else { 118 118 $icon = 'fa-times-circle-o'; 119 - $color = 'bluegrey'; 119 + $color = 'red'; 120 120 if ($authority_name !== null) { 121 121 $label = pht( 122 122 'Requested Changes to Prior Diff (by %s)',