@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When a user submits "isEditing" inlines and chooses to publish them, publish their current draft state as-shown
Summary: Ref T13513. When users choose to publish inlines, we want to publish the visible text, not the last "checkpointed" state.
Test Plan:
- Created an inline ("AAA").
- Edited it into "BBB", did not save.
- Submitted.
- Confirmed that I want to publish the unsaved inline.
- Saw "BBB" publish.
Maniphest Tasks: T13513
Differential Revision: https://secure.phabricator.com/D21218
+11
+11
src/applications/differential/query/DifferentialTransactionQuery.php
+11
src/applications/differential/query/DifferentialTransactionQuery.php
···
33
33
foreach ($inlines as $key => $inline) {
34
34
if ($inline->isVoidComment($viewer)) {
35
35
unset($inlines[$key]);
36
+
continue;
37
+
}
38
+
39
+
// For other inlines: if they have a nonempty draft state, set their
40
+
// content to the draft state content. We want to submit the comment
41
+
// as it is currently shown to the user, not as it was stored the last
42
+
// time they clicked "Save".
43
+
44
+
$draft_content = $inline->getContentForEdit($viewer);
45
+
if (strlen($draft_content)) {
46
+
$inline->setContent($draft_content);
36
47
}
37
48
}
38
49