@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add some style to label in Favorites Menu
Summary: Ref T12174. Always sets the correct type when converting to ActionList, adds a type to Divider.
Test Plan:
Add a Label, 2 applications to the personal favorites menu, see nice styles.
{F2554901}
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T12174
Differential Revision: https://secure.phabricator.com/D17285
+2
-5
+1
-5
src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php
+1
-5
src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php
···
61
61
$view = id(new PhabricatorActionListView())
62
62
->setViewer($viewer);
63
63
foreach ($item_views as $item) {
64
-
$type = null;
65
-
if (!strlen($item->getName())) {
66
-
$type = PhabricatorActionView::TYPE_DIVIDER;
67
-
}
68
64
$action = id(new PhabricatorActionView())
69
65
->setName($item->getName())
70
66
->setHref($item->getHref())
71
-
->setType($type);
67
+
->setType($item->getType());
72
68
$view->addAction($action);
73
69
}
74
70